linux-kernel - Re: [PATCH 1/9] serial: uartline: Fix BRKINT clearing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d96ccec0-f95e-4f56-a12c-c7c0461a1e7d@seco.com>
Date:   Tue, 17 May 2022 10:33:45 -0400
From:   Sean Anderson <sean.anderson@...o.com>
To:     Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>,
        linux-serial@...r.kernel.org, Greg KH <gregkh@...uxfoundation.org>,
        Jiri Slaby <jirislaby@...nel.org>,
        Peter Korsgaard <jacmet@...site.dk>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/9] serial: uartline: Fix BRKINT clearing



On 5/17/22 7:07 AM, Ilpo Järvinen wrote:
> BRKINT is within c_iflag rather than c_cflag.
> 
> Cc: Sean Anderson <sean.anderson@...o.com>
> Fixes: ea017f5853e9 (tty: serial: uartlite: Prevent changing fixed parameters)
> Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
> ---
>  drivers/tty/serial/uartlite.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/tty/serial/uartlite.c b/drivers/tty/serial/uartlite.c
> index 007db67292a2..880e2afbb97b 100644
> --- a/drivers/tty/serial/uartlite.c
> +++ b/drivers/tty/serial/uartlite.c
> @@ -321,7 +321,8 @@ static void ulite_set_termios(struct uart_port *port, struct ktermios *termios,
>  	struct uartlite_data *pdata = port->private_data;
>  
>  	/* Set termios to what the hardware supports */
> -	termios->c_cflag &= ~(BRKINT | CSTOPB | PARENB | PARODD | CSIZE);
> +	termios->c_iflag &= ~BRKINT;
> +	termios->c_cflag &= ~(CSTOPB | PARENB | PARODD | CSIZE);
>  	termios->c_cflag |= pdata->cflags & (PARENB | PARODD | CSIZE);
>  	tty_termios_encode_baud_rate(termios, pdata->baud, pdata->baud);
>  
> 

Reviewed-by: Sean Anderson <sean.anderson@...o.com>