linux-kernel - Re: [PATCH v3 0/2] Fix topdown event weak grouping

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YoO5Lp1UHMowHLmH@kernel.org>
Date:   Tue, 17 May 2022 12:03:10 -0300
From:   Arnaldo Carvalho de Melo <acme@...nel.org>
To:     Ian Rogers <irogers@...gle.com>
Cc:     Peter Zijlstra <peterz@...radead.org>,
        Ingo Molnar <mingo@...hat.com>,
        Mark Rutland <mark.rutland@....com>,
        Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
        Jiri Olsa <jolsa@...nel.org>,
        Namhyung Kim <namhyung@...nel.org>,
        Riccardo Mancini <rickyman7@...il.com>,
        Kim Phillips <kim.phillips@....com>,
        Madhavan Srinivasan <maddy@...ux.ibm.com>,
        Shunsuke Nakamura <nakamura.shun@...itsu.com>,
        Florian Fischer <florian.fischer@...q.space>,
        Andi Kleen <ak@...ux.intel.com>,
        John Garry <john.garry@...wei.com>,
        Zhengjun Xing <zhengjun.xing@...ux.intel.com>,
        Adrian Hunter <adrian.hunter@...el.com>,
        James Clark <james.clark@....com>,
        linux-perf-users@...r.kernel.org, linux-kernel@...r.kernel.org,
        Stephane Eranian <eranian@...gle.com>
Subject: Re: [PATCH v3 0/2] Fix topdown event weak grouping

Em Mon, May 16, 2022 at 10:27:22PM -0700, Ian Rogers escreveu:
> Keep topdown events within a group when a weak group is broken. This
> is a requirement as topdown events must form a group.
> 
> Add perf stat testing including for required topdown event group
> behaviors.
> 
> Note: as with existing topdown evsel/evlist code topdown events are
> assumed to be on the PMU "cpu". On Alderlake the PMU "cpu_core" should
> also be tested. Future changes can fix Alderlake.

Thanks, applied.

- Arnaldo

 
> v3. Fix computation of number of events in leader's group.
>     Adds reviewed-by: Liang, Kan <kan.liang@...ux.intel.com
> v2. Correct behavior wrt pmu prefixed events and avoid the test using
>     deprecated events: Suggested-by: Liang, Kan <kan.liang@...ux.intel.com>
> 
> Ian Rogers (2):
>   perf evlist: Keep topdown counters in weak group
>   perf test: Add basic stat and topdown group test
> 
>  tools/perf/arch/x86/util/evsel.c | 12 ++++++
>  tools/perf/tests/shell/stat.sh   | 67 ++++++++++++++++++++++++++++++++
>  tools/perf/util/evlist.c         | 16 +++++++-
>  tools/perf/util/evsel.c          | 10 +++++
>  tools/perf/util/evsel.h          |  3 ++
>  5 files changed, 106 insertions(+), 2 deletions(-)
>  create mode 100755 tools/perf/tests/shell/stat.sh
> 
> -- 
> 2.36.0.550.gb090851708-goog

-- 

- Arnaldo