linux-kernel - RE: [PATCH v2 2/3] ARM: dts: aspeed: Add USB2.0 device controller node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 17 May 2022 15:21:15 +0000
From:   Neal Liu <neal_liu@...eedtech.com>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Joel Stanley <joel@....id.au>,
        Andrew Jeffery <andrew@...id.au>,
        Felipe Balbi <balbi@...nel.org>,
        Sumit Semwal <sumit.semwal@...aro.org>,
        Christian König <christian.koenig@....com>,
        Geert Uytterhoeven <geert@...ux-m68k.org>,
        Li Yang <leoyang.li@....com>
CC:     "linux-aspeed@...ts.ozlabs.org" <linux-aspeed@...ts.ozlabs.org>,
        "linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-media@...r.kernel.org" <linux-media@...r.kernel.org>,
        "dri-devel@...ts.freedesktop.org" <dri-devel@...ts.freedesktop.org>,
        "linaro-mm-sig@...ts.linaro.org" <linaro-mm-sig@...ts.linaro.org>
Subject: RE: [PATCH v2 2/3] ARM: dts: aspeed: Add USB2.0 device controller
 node

> -----Original Message-----
> From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
> Sent: Tuesday, May 17, 2022 10:54 PM
> To: Neal Liu <neal_liu@...eedtech.com>; Greg Kroah-Hartman
> <gregkh@...uxfoundation.org>; Rob Herring <robh+dt@...nel.org>; Krzysztof
> Kozlowski <krzysztof.kozlowski+dt@...aro.org>; Joel Stanley <joel@....id.au>;
> Andrew Jeffery <andrew@...id.au>; Felipe Balbi <balbi@...nel.org>; Sumit
> Semwal <sumit.semwal@...aro.org>; Christian König
> <christian.koenig@....com>; Geert Uytterhoeven <geert@...ux-m68k.org>;
> Li Yang <leoyang.li@....com>
> Cc: linux-aspeed@...ts.ozlabs.org; linux-usb@...r.kernel.org;
> devicetree@...r.kernel.org; linux-arm-kernel@...ts.infradead.org;
> linux-kernel@...r.kernel.org; linux-media@...r.kernel.org;
> dri-devel@...ts.freedesktop.org; linaro-mm-sig@...ts.linaro.org
> Subject: Re: [PATCH v2 2/3] ARM: dts: aspeed: Add USB2.0 device controller
> node
> 
> On 17/05/2022 16:50, Neal Liu wrote:
> >> -----Original Message-----
> >> From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
> >> Sent: Tuesday, May 17, 2022 8:00 PM
> >> To: Neal Liu <neal_liu@...eedtech.com>; Greg Kroah-Hartman
> >> <gregkh@...uxfoundation.org>; Rob Herring <robh+dt@...nel.org>;
> >> Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>; Joel Stanley
> >> <joel@....id.au>; Andrew Jeffery <andrew@...id.au>; Felipe Balbi
> >> <balbi@...nel.org>; Sumit Semwal <sumit.semwal@...aro.org>; Christian
> >> König <christian.koenig@....com>; Geert Uytterhoeven
> >> <geert@...ux-m68k.org>; Li Yang <leoyang.li@....com>
> >> Cc: linux-aspeed@...ts.ozlabs.org; linux-usb@...r.kernel.org;
> >> devicetree@...r.kernel.org; linux-arm-kernel@...ts.infradead.org;
> >> linux-kernel@...r.kernel.org; linux-media@...r.kernel.org;
> >> dri-devel@...ts.freedesktop.org; linaro-mm-sig@...ts.linaro.org
> >> Subject: Re: [PATCH v2 2/3] ARM: dts: aspeed: Add USB2.0 device
> >> controller node
> >>
> >> On 17/05/2022 10:25, Neal Liu wrote:
> >>> Add USB2.0 device controller(udc) node to device tree for AST2600.
> >>>
> >>> Signed-off-by: Neal Liu <neal_liu@...eedtech.com>
> >>> ---
> >>>  arch/arm/boot/dts/aspeed-g6.dtsi | 10 ++++++++++
> >>>  1 file changed, 10 insertions(+)
> >>>
> >>> diff --git a/arch/arm/boot/dts/aspeed-g6.dtsi
> >>> b/arch/arm/boot/dts/aspeed-g6.dtsi
> >>> index 3d5ce9da42c3..5517313eb2b5 100644
> >>> --- a/arch/arm/boot/dts/aspeed-g6.dtsi
> >>> +++ b/arch/arm/boot/dts/aspeed-g6.dtsi
> >>> @@ -298,6 +298,16 @@ vhub: usb-vhub@...a0000 {
> >>>  			status = "disabled";
> >>>  		};
> >>>
> >>> +		udc: udc@...a2000 {
> >>
> >> The same as DTS in bindings - generic node name, please.
> >>
> >
> > Is it possible to use "udc: usb-udc@...a2000" to distinguish it between "vhub:
> usb-vhub@...a0000"?
> 
> Possible yes :), but not recommended and not wanted. Nodes should be generic
> and prefixes are added only if there is no unit address. You can though use
> some more descriptive label.
> 
"udc: usb@...a2000" is okay for you?

> 
> Best regards,
> Krzysztof