linux-kernel - Re: [PATCH] fs/ntfs: remove redundant variable idx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <D8033E52-4BB9-44E7-A97A-FB1E51645902@tuxera.com>
Date:   Tue, 17 May 2022 12:09:46 +0000
From:   Anton Altaparmakov <anton@...era.com>
To:     Andrew Morton <akpm@...ux-foundation.org>
CC:     "linux-ntfs-dev@...ts.sourceforge.net" 
        <linux-ntfs-dev@...ts.sourceforge.net>,
        "kernel-janitors@...r.kernel.org" <kernel-janitors@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Colin Ian King <colin.i.king@...il.com>
Subject: Re: [PATCH] fs/ntfs: remove redundant variable idx

Hi Andrew,

Please could you merge this?  Thanks a lot!

Best regards,

	Anton

> On 17 May 2022, at 10:36, Colin Ian King <colin.i.king@...il.com> wrote:
> 
> The variable idx is assigned a value and is never read. The variable
> is not used and is redundant, remove it.
> 
> Cleans up clang scan build warning:
> warning: Although the value stored to 'idx' is used in the enclosing
> expression, the value is never actually read from 'idx'
> [deadcode.DeadStores]
> 
> Signed-off-by: Colin Ian King <colin.i.king@...il.com>
Reviewed-by: Anton Altaparmakov <anton@...era.com>
> ---
> fs/ntfs/file.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/fs/ntfs/file.c b/fs/ntfs/file.c
> index e1392a9b8ceb..a8abe2296514 100644
> --- a/fs/ntfs/file.c
> +++ b/fs/ntfs/file.c
> @@ -1772,11 +1772,11 @@ static ssize_t ntfs_perform_write(struct file *file, struct iov_iter *i,
> 	last_vcn = -1;
> 	do {
> 		VCN vcn;
> -		pgoff_t idx, start_idx;
> +		pgoff_t start_idx;
> 		unsigned ofs, do_pages, u;
> 		size_t copied;
> 
> -		start_idx = idx = pos >> PAGE_SHIFT;
> +		start_idx = pos >> PAGE_SHIFT;
> 		ofs = pos & ~PAGE_MASK;
> 		bytes = PAGE_SIZE - ofs;
> 		do_pages = 1;
> -- 
> 2.35.1
>