linux-kernel - Re: (subset) [PATCH v7 00/11] spi: spi-mem: Convert Aspeed SMC driver to spi-mem

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 17 May 2022 13:10:44 +0100
From:   Mark Brown <broonie@...nel.org>
To:     Pratyush Yadav <p.yadav@...com>
Cc:     linux-spi@...r.kernel.org, linux-mtd@...ts.infradead.org,
        clg@...d.org, andrew@...id.au, robh+dt@...nel.org,
        devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        richard@....at, joel@....id.au, tudor.ambarus@...rochip.com,
        miquel.raynal@...tlin.com, chin-ting_kuo@...eedtech.com,
        linux-aspeed@...ts.ozlabs.org, vigneshr@...com,
        linux-kernel@...r.kernel.org
Subject: Re: (subset) [PATCH v7 00/11] spi: spi-mem: Convert Aspeed SMC
 driver to spi-mem

On Tue, May 17, 2022 at 04:35:09PM +0530, Pratyush Yadav wrote:
> On 16/05/22 07:39PM, Mark Brown wrote:
> > On Mon, 9 May 2022 19:56:05 +0200, Cédric Le Goater wrote:

> > [08/11] spi: aspeed: Calibrate read timings
> >         commit: eeaec1ea05c0e0f08e04c6844f20cc24a2fcc0f4

> I have repeatedly objected to this patch [0][1][2] and you have 
> repeatedly decided to not address my objections. I won't spend any more 
> time fighting it. But I will say that you should not expect any 
> guarantees that SPI NOR or SPI NAND will not break your calibration in 
> the future if they decide to move the dirmap_create() call around.

You == Cedric here.  Sorry, I thought that had been addressed as there
hadn't been anything I'd noticed on the thread for a few versions.  It
does look like there was agreement that there was a problem too :/

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)