linux-kernel - Re: [PATCH 1/3] kunit: tool: drop unused load

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CABVgOSmK94tTu4DMBMrmP934xXV4RD8CwmA8+NrV+YYbvWGxzQ@mail.gmail.com>
Date:   Wed, 18 May 2022 15:42:34 +0800
From:   David Gow <davidgow@...gle.com>
To:     Daniel Latypov <dlatypov@...gle.com>
Cc:     Brendan Higgins <brendanhiggins@...gle.com>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        KUnit Development <kunit-dev@...glegroups.com>,
        "open list:KERNEL SELFTEST FRAMEWORK" 
        <linux-kselftest@...r.kernel.org>,
        Shuah Khan <skhan@...uxfoundation.org>
Subject: Re: [PATCH 1/3] kunit: tool: drop unused load_config argument

On Tue, May 17, 2022 at 3:48 AM Daniel Latypov <dlatypov@...gle.com> wrote:
>
> It's always set to true except in one test case.
> And in that test case it can safely be set to true anyways.
>
> Signed-off-by: Daniel Latypov <dlatypov@...gle.com>
> ---

Looks good.

Reviewed-by: David Gow <davidgow@...gle.com>

-- David

>  tools/testing/kunit/kunit_kernel.py    | 4 ----
>  tools/testing/kunit/kunit_tool_test.py | 2 +-
>  2 files changed, 1 insertion(+), 5 deletions(-)
>
> diff --git a/tools/testing/kunit/kunit_kernel.py b/tools/testing/kunit/kunit_kernel.py
> index 3539efaf99ba..8bc8305ba817 100644
> --- a/tools/testing/kunit/kunit_kernel.py
> +++ b/tools/testing/kunit/kunit_kernel.py
> @@ -219,7 +219,6 @@ class LinuxSourceTree:
>         def __init__(
>               self,
>               build_dir: str,
> -             load_config=True,
>               kunitconfig_path='',
>               kconfig_add: Optional[List[str]]=None,
>               arch=None,
> @@ -233,9 +232,6 @@ class LinuxSourceTree:
>                         self._arch = 'um' if arch is None else arch
>                         self._ops = get_source_tree_ops(self._arch, cross_compile)
>
> -               if not load_config:
> -                       return
> -
>                 if kunitconfig_path:
>                         if os.path.isdir(kunitconfig_path):
>                                 kunitconfig_path = os.path.join(kunitconfig_path, KUNITCONFIG_PATH)
> diff --git a/tools/testing/kunit/kunit_tool_test.py b/tools/testing/kunit/kunit_tool_test.py
> index 25a2eb3bf114..b9158017ece6 100755
> --- a/tools/testing/kunit/kunit_tool_test.py
> +++ b/tools/testing/kunit/kunit_tool_test.py
> @@ -393,7 +393,7 @@ class LinuxSourceTreeTest(unittest.TestCase):
>                         return subprocess.Popen(['echo "hi\nbye"'], shell=True, text=True, stdout=subprocess.PIPE)
>
>                 with tempfile.TemporaryDirectory('') as build_dir:
> -                       tree = kunit_kernel.LinuxSourceTree(build_dir, load_config=False)
> +                       tree = kunit_kernel.LinuxSourceTree(build_dir)
>                         mock.patch.object(tree._ops, 'start', side_effect=fake_start).start()
>
>                         with self.assertRaises(ValueError):
>
> base-commit: 8a7ccad38f8b25c8202efd69371a022357286400
> --
> 2.36.1.124.g0e6072fb45-goog
>

Download attachment "smime.p7s" of type "application/pkcs7-signature" (4003 bytes)