linux-kernel - Re: [PATCH 2/6] dt-bindings: arm: mt8186: Set #clock-cells as required property

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 18 May 2022 11:30:39 +0200
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To:     AngeloGioacchino Del Regno 
        <angelogioacchino.delregno@...labora.com>, robh+dt@...nel.org
Cc:     krzysztof.kozlowski+dt@...aro.org, matthias.bgg@...il.com,
        sboyd@...nel.org, chun-jie.chen@...iatek.com,
        rex-bc.chen@...iatek.com, wenst@...omium.org,
        devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-mediatek@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/6] dt-bindings: arm: mt8186: Set #clock-cells as
 required property

On 18/05/2022 11:24, AngeloGioacchino Del Regno wrote:
> Il 17/05/22 16:34, Krzysztof Kozlowski ha scritto:
>> On 17/05/2022 12:15, AngeloGioacchino Del Regno wrote:
>>> This is a clock-controller binding, so it needs #clock-cells, or
>>> it would be of no use: add that to the list of required properties.
>>>
>>> Fixes: f113a51aa2cf ("dt-bindings: ARM: MediaTek: Add new document bindings of MT8186 clock")
>>> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>
>>> ---
>>>   .../devicetree/bindings/arm/mediatek/mediatek,mt8186-clock.yaml  | 1 +
>>
>> If these are clock controllers and new bindings, why they were added to
>> "arm" directory? arm is only for top-level stuff, not for devices.
>>
>> In the future please put your bindings in respective subsystem matching
>> the hardware. Fallback is soc directory, not arm.
>>
>> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
>>
> 
> Hello Krzysztof,
> 
> I agree with you about these bindings belonging to the clock directory.
> Should I add a patch to this series that moves all of the mtxxxx-clock
> and mtxxxx-sys-clock yaml files to the clock directory?

They should not be added there, but no need to shuffle things around...


Best regards,
Krzysztof