linux-kernel - [PATCH] media: atmel: atmel-isc: remove unneeded IS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 19 May 2022 14:52:33 +0800
From:   Guo Zhengkui <guozhengkui@...o.com>
To:     Eugen Hristev <eugen.hristev@...rochip.com>,
        Mauro Carvalho Chehab <mchehab@...nel.org>,
        Nicolas Ferre <nicolas.ferre@...rochip.com>,
        Alexandre Belloni <alexandre.belloni@...tlin.com>,
        Claudiu Beznea <claudiu.beznea@...rochip.com>,
        linux-media@...r.kernel.org (open list:MICROCHIP ISC DRIVER),
        linux-arm-kernel@...ts.infradead.org (moderated list:ARM/Microchip
        (AT91) SoC support), linux-kernel@...r.kernel.org (open list)
Cc:     zhengkui_guo@...look.com, Guo Zhengkui <guozhengkui@...o.com>
Subject: [PATCH] media: atmel: atmel-isc: remove unneeded IS_ERR()

There has already been error check in clk_unregister(), so remove error
check before calling clk_unregister().

Signed-off-by: Guo Zhengkui <guozhengkui@...o.com>
---
 drivers/media/platform/atmel/atmel-isc-clk.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/media/platform/atmel/atmel-isc-clk.c b/drivers/media/platform/atmel/atmel-isc-clk.c
index 2059fe376b00..9decd8fb03d5 100644
--- a/drivers/media/platform/atmel/atmel-isc-clk.c
+++ b/drivers/media/platform/atmel/atmel-isc-clk.c
@@ -304,8 +304,7 @@ void isc_clk_cleanup(struct isc_device *isc)
 	for (i = 0; i < ARRAY_SIZE(isc->isc_clks); i++) {
 		struct isc_clk *isc_clk = &isc->isc_clks[i];
 
-		if (!IS_ERR(isc_clk->clk))
-			clk_unregister(isc_clk->clk);
+		clk_unregister(isc_clk->clk);
 	}
 }
 EXPORT_SYMBOL_GPL(isc_clk_cleanup);
-- 
2.20.1