linux-kernel - Re: [PATCH] arm64: dts: qcom: sc7280: Enable wifi for Chrome OS boards

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAD=FV=X+4JhN8EScFDZAiduo6zy7c0pbr6EOJpSo25ctOW-zRA@mail.gmail.com>
Date:   Fri, 20 May 2022 13:07:53 -0700
From:   Doug Anderson <dianders@...omium.org>
To:     Matthias Kaehlcke <mka@...omium.org>
Cc:     Andy Gross <agross@...nel.org>,
        Bjorn Andersson <bjorn.andersson@...aro.org>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzk+dt@...nel.org>,
        linux-arm-msm <linux-arm-msm@...r.kernel.org>,
        Kevin Lund <kglund@...gle.com>,
        "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@...r.kernel.org>, LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] arm64: dts: qcom: sc7280: Enable wifi for Chrome OS boards

Hi,

On Wed, May 18, 2022 at 3:53 PM Matthias Kaehlcke <mka@...omium.org> wrote:
>
> Enable the 'wifi' and 'remoteproc_wpss' nodes for all sc7280
> based Chrome OS boards. Delete the corresponding entries from
> sc7280-idp.dtsi since this file includes sc7280-chrome-common.dtsi.
>
> Signed-off-by: Matthias Kaehlcke <mka@...omium.org>
> ---
>
>  arch/arm64/boot/dts/qcom/sc7280-chrome-common.dtsi | 13 +++++++++++++
>  arch/arm64/boot/dts/qcom/sc7280-idp.dtsi           | 11 -----------
>  2 files changed, 13 insertions(+), 11 deletions(-)

Looks right to me. You're also adding the firmware-name, but:

* That's in the bindings.

* The name you have there matches what's in the linux-firmware
repository in commit 0d5e9f7e0aa1 ("ath11k: WCN6750 hw1.0: add to
WLAN.MSL.1.0.1-00887-QCAMSLSWPLZ-1")

Hmmm, I guess one question is whether this same firmware would also be
used for other, non-Chrome sc7280 devices. If so then the
firmware-name probably belongs straight in sc7280.dtsi? I suppose that
could always happen in a future change if/when we have other sc7280
devices and it's clear that they're sharing firmware. Thus:

Reviewed-by: Douglas Anderson <dianders@...omium.org>

-Doug