lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 20 May 2022 13:35:19 -0700 From: Matthias Kaehlcke <mka@...omium.org> To: Doug Anderson <dianders@...omium.org> Cc: Andy Gross <agross@...nel.org>, Bjorn Andersson <bjorn.andersson@...aro.org>, Rob Herring <robh+dt@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>, linux-arm-msm <linux-arm-msm@...r.kernel.org>, Kevin Lund <kglund@...gle.com>, "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" <devicetree@...r.kernel.org>, LKML <linux-kernel@...r.kernel.org> Subject: Re: [PATCH] arm64: dts: qcom: sc7280: Enable wifi for Chrome OS boards On Fri, May 20, 2022 at 01:07:53PM -0700, Doug Anderson wrote: > Hi, > > On Wed, May 18, 2022 at 3:53 PM Matthias Kaehlcke <mka@...omium.org> wrote: > > > > Enable the 'wifi' and 'remoteproc_wpss' nodes for all sc7280 > > based Chrome OS boards. Delete the corresponding entries from > > sc7280-idp.dtsi since this file includes sc7280-chrome-common.dtsi. > > > > Signed-off-by: Matthias Kaehlcke <mka@...omium.org> > > --- > > > > arch/arm64/boot/dts/qcom/sc7280-chrome-common.dtsi | 13 +++++++++++++ > > arch/arm64/boot/dts/qcom/sc7280-idp.dtsi | 11 ----------- > > 2 files changed, 13 insertions(+), 11 deletions(-) > > Looks right to me. You're also adding the firmware-name, but: > > * That's in the bindings. > > * The name you have there matches what's in the linux-firmware > repository in commit 0d5e9f7e0aa1 ("ath11k: WCN6750 hw1.0: add to > WLAN.MSL.1.0.1-00887-QCAMSLSWPLZ-1") > > Hmmm, I guess one question is whether this same firmware would also be > used for other, non-Chrome sc7280 devices. If so then the > firmware-name probably belongs straight in sc7280.dtsi? I suppose that > could always happen in a future change if/when we have other sc7280 > devices and it's clear that they're sharing firmware. Thus: It could go either way. One of our wifi engineers mentioned that his contact at QC said the FW should reside directly in /lib/firmware, not in any sub-directory, which would be odd, but up to them ;-) > Reviewed-by: Douglas Anderson <dianders@...omium.org> Thanks!
Powered by blists - more mailing lists