linux-kernel - Re: [PATCH v2 03/28] vsprintf: %pf(%p)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220520044317.5ypfqjjgnlmt62tp@moria.home.lan>
Date:   Fri, 20 May 2022 00:43:17 -0400
From:   Kent Overstreet <kent.overstreet@...il.com>
To:     Matthew Wilcox <willy@...radead.org>
Cc:     linux-kernel@...r.kernel.org, linux-mm@...r.kernel.org,
        pmladek@...e.com, rostedt@...dmis.org, senozhatsky@...omium.org,
        andriy.shevchenko@...ux.intel.com
Subject: Re: [PATCH v2 03/28] vsprintf: %pf(%p)

On Thu, May 19, 2022 at 07:33:32PM +0100, Matthew Wilcox wrote:
> On Thu, May 19, 2022 at 01:23:56PM -0400, Kent Overstreet wrote:
> > +++ b/Documentation/core-api/printk-formats.rst
> > @@ -625,6 +625,25 @@ Examples::
> >  	%p4cc	Y10  little-endian (0x20303159)
> >  	%p4cc	NV12 big-endian (0xb231564e)
> >  
> > +Calling a pretty printer function
> > +---------------------------------
> > +
> > +::
> > +
> > +        %p(%p)     pretty printer function taking one argument
> > +        %p(%p,%p)  pretty printer function taking two arguments
> 
> Needs to be updated to the %pf change.
> 
> > +        printf("%p(%p)", foo_to_text, foo);
> 
> Likewise
> 
> Reviewed-by: Matthew Wilcox (Oracle) <willy@...radead.org>

Thanks - fixed.