linux-kernel - Re: [PATCH v2 01/28] lib/printbuf: New data structure for printing strings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220520044404.tdjnuenbunymuzrs@moria.home.lan>
Date:   Fri, 20 May 2022 00:44:04 -0400
From:   Kent Overstreet <kent.overstreet@...il.com>
To:     Matthew Wilcox <willy@...radead.org>
Cc:     linux-kernel@...r.kernel.org, linux-mm@...r.kernel.org,
        pmladek@...e.com, rostedt@...dmis.org, senozhatsky@...omium.org,
        andriy.shevchenko@...ux.intel.com
Subject: Re: [PATCH v2 01/28] lib/printbuf: New data structure for printing
 strings

On Thu, May 19, 2022 at 07:21:00PM +0100, Matthew Wilcox wrote:
> On Thu, May 19, 2022 at 01:23:54PM -0400, Kent Overstreet wrote:
> > This adds printbufs: a printbuf points to a char * buffer and knows the
> > size of the output buffer as well as the current output position.
> > 
> > Future patches will be adding more features to printbuf, but initially
> > printbufs are targeted at refactoring and improving our existing code in
> > lib/vsprintf.c - so this initial printbuf patch has the features
> > required for that.
> > 
> > Signed-off-by: Kent Overstreet <kent.overstreet@...il.com>
> 
> Reviewed-by: Matthew Wilcox (Oracle) <willy@...radead.org>
> 
> My only complaint ...
> 
> > +#define PRINTBUF ((struct printbuf) { .si_units = PRINTBUF_UNITS_10 })
> 
> si_units doesn't exist yet :-)

Thanks, also fixed :)