linux-kernel - Re: [PATCH] nfs: removed goto statement

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <B70C3673-8CBF-414D-9D8A-BAD4F30FA9D9@redhat.com>
Date:   Fri, 20 May 2022 08:41:26 -0400
From:   "Benjamin Coddington" <bcodding@...hat.com>
To:     "Javier Abrego Lorente" <javier.abrego.lorente@...il.com>
Cc:     trond.myklebust@...merspace.com, anna@...nel.org,
        linux-nfs@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] nfs: removed goto statement

On 20 May 2022, at 8:00, Javier Abrego Lorente wrote:

> final version, I promise.

Javier, please read "7) Centralized exiting of functions" in
Documentation/process/coding-style.rst.  The maintainers are unlikely to
take this patch because it doesn't (my opinion) improve the readability, and
removing a goto isn't a valid reason on its own.  The use of goto is an
acceptable practice in the linux kernel for some patterns.

Ben