linux-kernel - Re: [PATCH] splice: allow direct splicing with chardevs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <938111ca-d3c7-9888-24f8-0017a989002b@kernel.dk>
Date:   Fri, 20 May 2022 08:34:25 -0600
From:   Jens Axboe <axboe@...nel.dk>
To:     "Jason A. Donenfeld" <Jason@...c4.com>,
        linux-kernel@...r.kernel.org, viro@...iv.linux.org.uk
Cc:     Jens Axboe <axboe@...e.de>
Subject: Re: [PATCH] splice: allow direct splicing with chardevs

On 5/20/22 3:57 AM, Jason A. Donenfeld wrote:
> The original direct splicing mechanism from Jens required the input to
> be a regular file because it was avoiding the special socket case. It
> also recognized blkdevs as being close enough to a regular file. But it
> forgot about chardevs, which behave the same way and work fine here.
> 
> This commit adds the missing S_ISCHR condition so that chardevs such as
> /dev/urandom can be directly spliced without strangely returning
> -EINVAL.

Should be fine to turn this on for char devices:

Reviewed-by: Jens Axboe <axboe@...nel.dk>

-- 
Jens Axboe