linux-kernel - Re: [PATCH] splice: allow direct splicing with chardevs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHmME9pSZYZSz3YLRK7onO0E6zq9_B1GNwoTOkEQy_kws200Fw@mail.gmail.com>
Date:   Thu, 26 May 2022 23:19:46 +0200
From:   "Jason A. Donenfeld" <Jason@...c4.com>
To:     viro@...iv.linux.org.uk
Cc:     linux-kernel@...r.kernel.org, Jens Axboe <axboe@...nel.dk>
Subject: Re: [PATCH] splice: allow direct splicing with chardevs

Hey Al,

On 5/20/22, Jens Axboe <axboe@...nel.dk> wrote:
> On 5/20/22 3:57 AM, Jason A. Donenfeld wrote:
>> The original direct splicing mechanism from Jens required the input to
>> be a regular file because it was avoiding the special socket case. It
>> also recognized blkdevs as being close enough to a regular file. But it
>> forgot about chardevs, which behave the same way and work fine here.
>>
>> This commit adds the missing S_ISCHR condition so that chardevs such as
>> /dev/urandom can be directly spliced without strangely returning
>> -EINVAL.
>
> Should be fine to turn this on for char devices:
>
> Reviewed-by: Jens Axboe <axboe@...nel.dk>
>

Was wondering if this would make 5.19. That'd be nice, as it's the
release in which we switch to read_iter().

Jason