linux-kernel - Re: [PATCH v6 1/3] phy: qcom-edp: add regulator_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <609bb4fc-1503-81ef-6fd8-dbb862c4ef80@quicinc.com>
Date:   Fri, 20 May 2022 08:09:36 -0700
From:   Kuogee Hsieh <quic_khsieh@...cinc.com>
To:     Stephen Boyd <swboyd@...omium.org>, <agross@...nel.org>,
        <airlied@...ux.ie>, <bjorn.andersson@...aro.org>,
        <daniel@...ll.ch>, <dianders@...omium.org>,
        <dmitry.baryshkov@...aro.org>, <dri-devel@...ts.freedesktop.org>,
        <robdclark@...il.com>, <sean@...rly.run>, <vkoul@...nel.org>
CC:     <quic_abhinavk@...cinc.com>, <quic_aravindh@...cinc.com>,
        <quic_sbillaka@...cinc.com>, <freedreno@...ts.freedesktop.org>,
        <linux-arm-msm@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v6 1/3] phy: qcom-edp: add regulator_set_load to edp phy


On 5/19/2022 5:19 PM, Stephen Boyd wrote:
> Quoting Kuogee Hsieh (2022-05-19 16:11:40)
>> diff --git a/drivers/phy/qualcomm/phy-qcom-edp.c b/drivers/phy/qualcomm/phy-qcom-edp.c
>> index cacd32f..78b7306 100644
>> --- a/drivers/phy/qualcomm/phy-qcom-edp.c
>> +++ b/drivers/phy/qualcomm/phy-qcom-edp.c
>> @@ -87,14 +87,19 @@ struct qcom_edp {
>>
>>          struct clk_bulk_data clks[2];
>>          struct regulator_bulk_data supplies[2];
>> +       int enable_load[2];
>>   };
>>
>>   static int qcom_edp_phy_init(struct phy *phy)
>>   {
>>          struct qcom_edp *edp = phy_get_drvdata(phy);
>>          int ret;
>> +       int i;
>>
>> -       ret = regulator_bulk_enable(ARRAY_SIZE(edp->supplies), edp->supplies);
>> +       for (i = 0; i < 2; i++)
> Use ARRAY_SIZE(edp->supplies)?
>
>> +               regulator_set_load(edp->supplies[i].consumer, edp->enable_load[i]);
>> +
>> +       ret = regulator_bulk_enable(2, edp->supplies);
> Why is ARRAY_SIZE() usage removed?


remove it base on Dmitry's comment.

I will restore it back to use ARRY_SIZE


>
>>          if (ret)
>>                  return ret;
>>