linux-kernel - Re: [PATCH -next] cpufreq: CPPC: Fix build error without CONFIG_ACPI_CPPC_CPUFREQ

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220523065850.lhnpsc2u3dxzzwx7@vireshk-i7>
Date:   Mon, 23 May 2022 12:28:50 +0530
From:   Viresh Kumar <viresh.kumar@...aro.org>
To:     Zheng Bin <zhengbin13@...wei.com>
Cc:     rafael@...nel.org, Pierre.Gondois@....com,
        linux-pm@...r.kernel.org, linux-kernel@...r.kernel.org,
        gaochao49@...wei.com
Subject: Re: [PATCH -next] cpufreq: CPPC: Fix build error without
 CONFIG_ACPI_CPPC_CPUFREQ_FIE

On 21-05-22, 11:24, Zheng Bin wrote:
> If CONFIG_ACPI_CPPC_CPUFREQ_FIE is not set, building fails:
> 
> drivers/cpufreq/cppc_cpufreq.c: In function ‘populate_efficiency_class’:
> drivers/cpufreq/cppc_cpufreq.c:584:2: error: ‘cppc_cpufreq_driver’ undeclared (first use in this function); did you mean ‘cpufreq_driver’?
>   cppc_cpufreq_driver.register_em = cppc_cpufreq_register_em;
>   ^~~~~~~~~~~~~~~~~~~
>   cpufreq_driver
> 
> Make declare of cppc_cpufreq_driver out of CONFIG_ACPI_CPPC_CPUFREQ_FIE
> to fix this.
> 
> Fixes: 740fcdc2c20e ("cpufreq: CPPC: Register EM based on efficiency class information")
> Signed-off-by: Zheng Bin <zhengbin13@...wei.com>
> ---
>  drivers/cpufreq/cppc_cpufreq.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)

Acked-by: Viresh Kumar <viresh.kumar@...aro.org>

-- 
viresh