linux-kernel - Re: [PATCH -next] cpufreq: CPPC: Fix build error without CONFIG_ACPI_CPPC_CPUFREQ

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAJZ5v0j_jzc1zN+qU6sZEASV_e-4Zuqzbq2k=WrJAuYM1XXhjg@mail.gmail.com>
Date:   Mon, 30 May 2022 15:32:23 +0200
From:   "Rafael J. Wysocki" <rafael@...nel.org>
To:     Viresh Kumar <viresh.kumar@...aro.org>,
        Zheng Bin <zhengbin13@...wei.com>
Cc:     "Rafael J. Wysocki" <rafael@...nel.org>,
        Pierre Gondois <Pierre.Gondois@....com>,
        Linux PM <linux-pm@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        gaochao49@...wei.com
Subject: Re: [PATCH -next] cpufreq: CPPC: Fix build error without CONFIG_ACPI_CPPC_CPUFREQ_FIE

On Mon, May 23, 2022 at 8:58 AM Viresh Kumar <viresh.kumar@...aro.org> wrote:
>
> On 21-05-22, 11:24, Zheng Bin wrote:
> > If CONFIG_ACPI_CPPC_CPUFREQ_FIE is not set, building fails:
> >
> > drivers/cpufreq/cppc_cpufreq.c: In function ‘populate_efficiency_class’:
> > drivers/cpufreq/cppc_cpufreq.c:584:2: error: ‘cppc_cpufreq_driver’ undeclared (first use in this function); did you mean ‘cpufreq_driver’?
> >   cppc_cpufreq_driver.register_em = cppc_cpufreq_register_em;
> >   ^~~~~~~~~~~~~~~~~~~
> >   cpufreq_driver
> >
> > Make declare of cppc_cpufreq_driver out of CONFIG_ACPI_CPPC_CPUFREQ_FIE
> > to fix this.
> >
> > Fixes: 740fcdc2c20e ("cpufreq: CPPC: Register EM based on efficiency class information")
> > Signed-off-by: Zheng Bin <zhengbin13@...wei.com>
> > ---
> >  drivers/cpufreq/cppc_cpufreq.c | 3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
>
> Acked-by: Viresh Kumar <viresh.kumar@...aro.org>

Applied, thanks!