lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 23 May 2022 11:11:45 +0000 From: cgel.zte@...il.com To: joro@...tes.org Cc: will@...nel.org, iommu@...ts.linux-foundation.org, linux-kernel@...r.kernel.org, Minghao Chi <chi.minghao@....com.cn>, Zeal Robot <zealci@....com.cn> Subject: [PATCH] iommu/ipmmu-vmsa: Avoid leak OF node on error From: Minghao Chi <chi.minghao@....com.cn> The OF node should be put before returning error in ipmmu_init(), otherwise node's refcount will be leaked. Reported-by: Zeal Robot <zealci@....com.cn> Signed-off-by: Minghao Chi <chi.minghao@....com.cn> --- drivers/iommu/ipmmu-vmsa.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/iommu/ipmmu-vmsa.c b/drivers/iommu/ipmmu-vmsa.c index 8fdb84b3642b..f6440b106f46 100644 --- a/drivers/iommu/ipmmu-vmsa.c +++ b/drivers/iommu/ipmmu-vmsa.c @@ -1179,11 +1179,10 @@ static int __init ipmmu_init(void) return 0; np = of_find_matching_node(NULL, ipmmu_of_ids); + of_node_put(np); if (!np) return 0; - of_node_put(np); - ret = platform_driver_register(&ipmmu_driver); if (ret < 0) return ret; -- 2.25.1
Powered by blists - more mailing lists