[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <Yot13L7XgvxTkgnE@hovoldconsulting.com>
Date: Mon, 23 May 2022 13:54:04 +0200
From: Johan Hovold <johan@...nel.org>
To: cgel.zte@...il.com
Cc: joro@...tes.org, will@...nel.org, iommu@...ts.linux-foundation.org,
linux-kernel@...r.kernel.org, Minghao Chi <chi.minghao@....com.cn>,
Zeal Robot <zealci@....com.cn>
Subject: Re: [PATCH] iommu/ipmmu-vmsa: Avoid leak OF node on error
On Mon, May 23, 2022 at 11:11:45AM +0000, cgel.zte@...il.com wrote:
> From: Minghao Chi <chi.minghao@....com.cn>
>
> The OF node should be put before returning error in ipmmu_init(),
> otherwise node's refcount will be leaked.
>
> Reported-by: Zeal Robot <zealci@....com.cn>
> Signed-off-by: Minghao Chi <chi.minghao@....com.cn>
> ---
> drivers/iommu/ipmmu-vmsa.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/iommu/ipmmu-vmsa.c b/drivers/iommu/ipmmu-vmsa.c
> index 8fdb84b3642b..f6440b106f46 100644
> --- a/drivers/iommu/ipmmu-vmsa.c
> +++ b/drivers/iommu/ipmmu-vmsa.c
> @@ -1179,11 +1179,10 @@ static int __init ipmmu_init(void)
> return 0;
>
> np = of_find_matching_node(NULL, ipmmu_of_ids);
> + of_node_put(np);
> if (!np)
> return 0;
>
> - of_node_put(np);
> -
> ret = platform_driver_register(&ipmmu_driver);
> if (ret < 0)
> return ret;
NAK
Powered by blists - more mailing lists