linux-kernel - Re: [PATCH] scsi: qla2xxx: remove setting of 'req' and 'rsp' parameter

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <A39923A2-373C-4EF8-997B-2A12821ED4E8@oracle.com>
Date:   Tue, 24 May 2022 18:10:18 +0000
From:   Himanshu Madhani <himanshu.madhani@...cle.com>
To:     Tom Rix <trix@...hat.com>
CC:     Nilesh Javali <njavali@...vell.com>,
        "James E.J. Bottomley" <jejb@...ux.ibm.com>,
        Martin Petersen <martin.petersen@...cle.com>,
        GR-QLogic-Storage-Upstream <GR-QLogic-Storage-Upstream@...vell.com>,
        linux-scsi <linux-scsi@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] scsi: qla2xxx: remove setting of 'req' and 'rsp'
 parameter



> On May 21, 2022, at 1:16 PM, Tom Rix <trix@...hat.com> wrote:
> 
> cppcheck reports
> [drivers/scsi/qla2xxx/qla_mid.c:594]: (warning) Assignment of function parameter has no effect outside the function. Did you forget dereferencing it?
> [drivers/scsi/qla2xxx/qla_mid.c:620]: (warning) Assignment of function parameter has no effect outside the function. Did you forget dereferencing it?
> 
> The functions qla25xx_free_req_que and qla25xx_free_rsp_que are similar.
> They free a 'req' and a 'rsp' parameter respectively.  The last statement of
> both functions is setting the parameter to NULL.  This has no effect and
> can be removed.
> 
> Signed-off-by: Tom Rix <trix@...hat.com>
> ---
> drivers/scsi/qla2xxx/qla_mid.c | 2 --
> 1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/scsi/qla2xxx/qla_mid.c b/drivers/scsi/qla2xxx/qla_mid.c
> index e6b5c4ccce97..346d47b61c07 100644
> --- a/drivers/scsi/qla2xxx/qla_mid.c
> +++ b/drivers/scsi/qla2xxx/qla_mid.c
> @@ -591,7 +591,6 @@ qla25xx_free_req_que(struct scsi_qla_host *vha, struct req_que *req)
> 	}
> 	kfree(req->outstanding_cmds);
> 	kfree(req);
> -	req = NULL;
> }
> 
> static void
> @@ -617,7 +616,6 @@ qla25xx_free_rsp_que(struct scsi_qla_host *vha, struct rsp_que *rsp)
> 		mutex_unlock(&ha->vport_lock);
> 	}
> 	kfree(rsp);
> -	rsp = NULL;
> }
> 
> int
> -- 
> 2.27.0
> 

Reviewed-by: Himanshu Madhani <himanshu.madhani@...cle.com>

--
Himanshu Madhani	Oracle Linux Engineering