linux-kernel - RE: [PATCH v2] dt-bindings: watchdog: toshiba,visconti-wdt: Update the common clock properties

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <TYWPR01MB9420E232FCA29F1CB07C0C8C92D69@TYWPR01MB9420.jpnprd01.prod.outlook.com>
Date:   Wed, 25 May 2022 00:41:59 +0000
From:   <nobuhiro1.iwamatsu@...hiba.co.jp>
To:     <linux@...ck-us.net>, <wim@...ux-watchdog.org>
CC:     <linux-watchdog@...r.kernel.org>, <yuji2.ishikawa@...hiba.co.jp>,
        <linux-arm-kernel@...ts.infradead.org>,
        <linux-kernel@...r.kernel.org>, <devicetree@...r.kernel.org>,
        <robh+dt@...nel.org>, <krzk+dt@...nel.org>, <robh@...nel.org>
Subject: RE: [PATCH v2] dt-bindings: watchdog: toshiba,visconti-wdt: Update
 the common clock properties

Hi Guenter,

Thanks for your review.

> -----Original Message-----
> From: Guenter Roeck <groeck7@...il.com> On Behalf Of Guenter Roeck
> Sent: Friday, May 20, 2022 6:11 PM
> To: iwamatsu nobuhiro(岩松 信洋 □ＳＷＣ◯ＡＣＴ)
> <nobuhiro1.iwamatsu@...hiba.co.jp>; Wim Van Sebroeck
> <wim@...ux-watchdog.org>
> Cc: linux-watchdog@...r.kernel.org; ishikawa yuji(石川 悠司 ○ＲＤＣ□ＡＩ
> ＴＣ○ＥＡ開) <yuji2.ishikawa@...hiba.co.jp>;
> linux-arm-kernel@...ts.infradead.org; linux-kernel@...r.kernel.org;
> devicetree@...r.kernel.org; Rob Herring <robh+dt@...nel.org>; Krzysztof
> Kozlowski <krzk+dt@...nel.org>; Rob Herring <robh@...nel.org>
> Subject: Re: [PATCH v2] dt-bindings: watchdog: toshiba,visconti-wdt: Update
> the common clock properties
> 
> On 5/20/22 02:00, Nobuhiro Iwamatsu wrote:
> > The clock for this driver switched to the common clock controller driver.
> > Therefore, update common clock properties for watchdog in the binding
> document.
> > And this matched this example with the actual dts.
> >
> > Signed-off-by: Nobuhiro Iwamatsu <nobuhiro1.iwamatsu@...hiba.co.jp>
> > Acked-by: Rob Herring <robh@...nel.org>
> > ---
> >   .../bindings/watchdog/toshiba,visconti-wdt.yaml     | 13
> ++++---------
> >   1 file changed, 4 insertions(+), 9 deletions(-)
> >
> > diff --git
> >
> a/Documentation/devicetree/bindings/watchdog/toshiba,visconti-wdt.yaml
> >
> b/Documentation/devicetree/bindings/watchdog/toshiba,visconti-wdt.yaml
> > index 690e19ce4b87..52c0e0c022ea 100644
> > ---
> >
> a/Documentation/devicetree/bindings/watchdog/toshiba,visconti-wdt.yaml
> > +++
> b/Documentation/devicetree/bindings/watchdog/toshiba,visconti-wdt.
> > +++ yaml
> > @@ -35,20 +35,15 @@ additionalProperties: false
> >
> >   examples:
> >     - |
> > +    #include <dt-bindings/clock/toshiba,tmpv770x.h>
> > +
> >       soc {
> >           #address-cells = <2>;
> >           #size-cells = <2>;
> >
> > -        wdt_clk: wdt-clk {
> > -            compatible = "fixed-clock";
> > -            clock-frequency = <150000000>;
> > -            #clock-cells = <0>;
> > -        };
> > -
> > -        watchdog@...30000 {
> > +        wdt: watchdog@...30000 {
> >               compatible = "toshiba,visconti-wdt";
> >               reg = <0 0x28330000 0 0x1000>;
> > -            clocks = <&wdt_clk>;
> > -            timeout-sec = <20>;
> > +            clocks = <&pismu TMPV770X_CLK_WDTCLK>;
> >           };
> >       };
> 
> wdt: isn't needed in the example, and I question if it really improves the quality
> of the example to remove timeout-sec.

OK, I make a fix that doesn't remove timeout-sec.

Best regards,
  Nobuhiro