lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 25 May 2022 10:14:43 +0200 From: Paolo Bonzini <pbonzini@...hat.com> To: Like Xu <like.xu.linux@...il.com>, Vitaly Kuznetsov <vkuznets@...hat.com> Cc: Sean Christopherson <seanjc@...gle.com>, Wanpeng Li <wanpengli@...cent.com>, Joerg Roedel <joro@...tes.org>, linux-kernel@...r.kernel.org, kvm@...r.kernel.org, Jim Mattson <jmattson@...gle.com> Subject: Re: [PATCH RESEND v12 00/17] KVM: x86/pmu: Add basic support to enable guest PEBS via DS On 5/25/22 09:56, Like Xu wrote: > Thanks for the clarification. > > Some kvm x86 selftests have been failing due to this issue even after > the last commit. > > I blame myself for not passing the msr_info->host_initiated to the > intel_is_valid_msr(), > meanwhile I pondered further whether we should check only the MSR addrs > range in > the kvm_pmu_is_valid_msr() and apply this kind of sanity check in the > pmu_set/get_msr(). > > Vitaly && Paolo, any preference to move forward ? I'm not sure what I did wrong to not see the failure, so I'll fix it myself. But from now on, I'll have a hard rule of no new processor features enabled without KVM unit tests or selftests. In fact, it would be nice if you wrote some for PEBS. Paolo
Powered by blists - more mailing lists