linux-kernel - Re: [PATCH v7 1/1] firmware: mediatek: add adsp ipc protocol interface

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ae47e12b-396c-a5a0-2da2-2010237fbbc2@collabora.com>
Date:   Wed, 25 May 2022 12:41:41 +0200
From:   AngeloGioacchino Del Regno 
        <angelogioacchino.delregno@...labora.com>
To:     Allen-KH Cheng <allen-kh.cheng@...iatek.com>,
        Matthias Brugger <matthias.bgg@...il.com>,
        Mark Brown <broonie@...nel.org>
Cc:     Kevin Hilman <khilman@...libre.com>,
        Linux-ALSA <alsa-devel@...a-project.org>, tzungbi@...gle.com,
        Chen-Yu Tsai <wenst@...omium.org>, cujomalainey@...gle.com,
        Pierre-Louis Bossart <pierre-louis.bossart@...ux.intel.com>,
        Liam Girdwood <lgirdwood@...il.com>,
        Ranjani Sridharan <ranjani.sridharan@...ux.intel.com>,
        Kai Vehmanen <kai.vehmanen@...ux.intel.com>,
        Daniel Baluta <daniel.baluta@....com>,
        Jaroslav Kysela <perex@...ex.cz>,
        Takashi Iwai <tiwai@...e.com>,
        Project_Global_Chrome_Upstream_Group@...iatek.com,
        linux-kernel@...r.kernel.org, devicetree@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org,
        linux-mediatek@...ts.infradead.org,
        sound-open-firmware@...a-project.org
Subject: Re: [PATCH v7 1/1] firmware: mediatek: add adsp ipc protocol
 interface

Il 25/05/22 12:39, AngeloGioacchino Del Regno ha scritto:
> Il 07/04/22 15:03, Allen-KH Cheng ha scritto:
>> From: Allen-KH Cheng <Allen-KH.Cheng@...iatek.com>
>>
>> Some of mediatek processors contain
>> the Tensilica HiFix DSP for audio processing.
>>
>> The communication between Host CPU and DSP firmware is
>> taking place using a shared memory area for message passing.
>>
>> ADSP IPC protocol offers (send/recv) interfaces using
>> mediatek-mailbox APIs.
>>
>> We use two mbox channels to implement a request-reply protocol.
>>
>> Signed-off-by: Allen-KH Cheng <allen-kh.cheng@...iatek.com>
>> Reviewed-by: Pierre-Louis Bossart <pierre-louis.bossart@...ux.intel.com>
>> Reviewed-by: Curtis Malainey <cujomalainey@...omium.org>
>> Reviewed-by: Tzung-Bi Shih <tzungbi@...gle.com>
>> Reviewed-by: YC Hung <yc.hung@...iatek.com>
>> Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>
>> ---
>>   drivers/firmware/Kconfig                      |   1 +
>>   drivers/firmware/Makefile                     |   1 +
>>   drivers/firmware/mediatek/Kconfig             |   9 +
>>   drivers/firmware/mediatek/Makefile            |   2 +
>>   drivers/firmware/mediatek/mtk-adsp-ipc.c      | 161 ++++++++++++++++++
>>   .../linux/firmware/mediatek/mtk-adsp-ipc.h    |  65 +++++++
>>   6 files changed, 239 insertions(+)
>>   create mode 100644 drivers/firmware/mediatek/Kconfig
>>   create mode 100644 drivers/firmware/mediatek/Makefile
>>   create mode 100644 drivers/firmware/mediatek/mtk-adsp-ipc.c
>>   create mode 100644 include/linux/firmware/mediatek/mtk-adsp-ipc.h
>>
> 
> Gentle ping for this one, as it's getting stale... and it's ready.
> 
> To add context, this driver is *really* necessary, as support for it
> is added in the MT8195 ASoC SOF driver as a platform device [1], and the
> necessary memory regions are coming from the mediatek,mt8195-dsp [2] driver.
> 
> [1]: 
> https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/tree/sound/soc/sof/mediatek/mt8195/mt8195.c?h=next-20220525#n389 
> 
> 
> [2]: 
> https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/tree/Documentation/devicetree/bindings/dsp/mediatek,mt8195-dsp.yaml?h=next-20220525#n61 
> 
> 
> Cheers,
> Angelo


I'm sorry, ignore me, another version of this one was already merged.