linux-kernel - Re: [PATCH 5.10 07/97] igc: Update I226

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220525104503.GA30018@duo.ucw.cz>
Date:   Wed, 25 May 2022 12:45:03 +0200
From:   Pavel Machek <pavel@....cz>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     linux-kernel@...r.kernel.org, stable@...r.kernel.org,
        Sasha Neftin <sasha.neftin@...el.com>,
        Nechama Kraus <nechamax.kraus@...ux.intel.com>,
        Tony Nguyen <anthony.l.nguyen@...el.com>,
        Nobuhiro Iwamatsu <nobuhiro1.iwamatsu@...hiba.co.jp>
Subject: Re: [PATCH 5.10 07/97] igc: Update I226_K device ID

Hi!

> From: Sasha Neftin <sasha.neftin@...el.com>
> 
> commit 79cc8322b6d82747cb63ea464146c0bf5b5a6bc1 upstream.
> 
> The device ID for I226_K was incorrectly assigned, update the device
> ID to the correct one.
> 
> Fixes: bfa5e98c9de4 ("igc: Add new device ID")

I don't see updating the ID, I see adding an unused define. I don't
think this is suitable for stable. Same thing goes for previous two
patches, they don't really fix anything.

5106 O   Greg Kroah ├─>[PATCH 5.10 05/97] igc: Remove _I_PHY_ID checking
5107 O   Greg Kroah ├─>[PATCH 5.10 06/97] igc: Remove phy->type checking
5108     Greg Kroah ├─>[PATCH 5.10 07/97] igc: Update I226_K device ID

Best regards,
								Pavel
								
> +++ b/drivers/net/ethernet/intel/igc/igc_hw.h
> @@ -22,6 +22,7 @@
>  #define IGC_DEV_ID_I220_V			0x15F7
>  #define IGC_DEV_ID_I225_K			0x3100
>  #define IGC_DEV_ID_I225_K2			0x3101
> +#define IGC_DEV_ID_I226_K			0x3102
>  #define IGC_DEV_ID_I225_LMVP			0x5502
>  #define IGC_DEV_ID_I225_IT			0x0D9F
>  #define IGC_DEV_ID_I226_LM			0x125B
> 

-- 
People of Russia, stop Putin before his war on Ukraine escalates.

Download attachment "signature.asc" of type "application/pgp-signature" (196 bytes)