lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 25 May 2022 17:14:52 +0200 From: Marco Pagani <marpagan@...hat.com> To: Moritz Fischer <mdf@...nel.org>, Wu Hao <hao.wu@...el.com>, Xu Yilun <yilun.xu@...el.com>, Tom Rix <trix@...hat.com> Cc: Marco Pagani <marpagan@...hat.com>, linux-fpga@...r.kernel.org, linux-kernel@...r.kernel.org Subject: [PATCH v2] fpga: altera-pr-ip: fix unsigned comparison with less than zero Fix the "comparison with less than zero" warning reported by cppcheck for the unsigned (size_t) parameter count of the alt_pr_fpga_write() function. Reviewed-by: Tom Rix <trix@...hat.com> Acked-by: Xu Yilun <yilun.xu@...el.com> Signed-off-by: Marco Pagani <marpagan@...hat.com> --- Changes v1 -> v2: - Coding style fix --- drivers/fpga/altera-pr-ip-core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/fpga/altera-pr-ip-core.c b/drivers/fpga/altera-pr-ip-core.c index be0667968d33..df8671af4a92 100644 --- a/drivers/fpga/altera-pr-ip-core.c +++ b/drivers/fpga/altera-pr-ip-core.c @@ -108,7 +108,7 @@ static int alt_pr_fpga_write(struct fpga_manager *mgr, const char *buf, u32 *buffer_32 = (u32 *)buf; size_t i = 0; - if (count <= 0) + if (!count) return -EINVAL; /* Write out the complete 32-bit chunks */ -- 2.35.3
Powered by blists - more mailing lists