linux-kernel - Re: [PATCH] workqueue: Fix type of cpu in trace event

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Yo/NPkJW9vnuHBcr@slm.duckdns.org>
Date:   Thu, 26 May 2022 08:55:58 -1000
From:   Tejun Heo <tj@...nel.org>
To:     Steven Rostedt <rostedt@...dmis.org>
Cc:     Wonhyuk Yang <vvghjk1234@...il.com>,
        Ingo Molnar <mingo@...hat.com>,
        Baik Song An <bsahn@...i.re.kr>,
        Hong Yeon Kim <kimhy@...i.re.kr>,
        Taeung Song <taeung@...llinux.co.kr>, linuxgeek@...uxgeek.io,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] workqueue: Fix type of cpu in trace event

On Tue, May 24, 2022 at 04:29:12PM -0400, Steven Rostedt wrote:
> On Wed,  4 May 2022 11:32:03 +0900
> Wonhyuk Yang <vvghjk1234@...il.com> wrote:
> 
> > The trace event "workqueue_queue_work" use unsigned int type for
> > req_cpu, cpu. This casue confusing cpu number like below log.
> > 
> > $ cat /sys/kernel/debug/tracing/trace
> > cat-317  [001] ...: workqueue_queue_work: ... req_cpu=8192 cpu=4294967295
> > 
> > So, change unsigned type to signed type in the trace event. After
> > applying this patch, cpu number will be printed as -1 instead of
> > 4294967295 as folllows.
> > 
> 
> I was going through my backlog of pending patches and came across this.
> Note, that trace events are maintained by the subsystem they belong to.
> This change is for workqueues, not tracing (as your subject correctly
> states).
> 
> I Cc'd Tejun here as he maintains this code.

I'll apply it to the wq tree once rc1 drops.

Thanks.

-- 
tejun