linux-kernel - Re: [PATCH] workqueue: Fix type of cpu in trace event

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Yp+Ge8aITdgczA33@slm.duckdns.org>
Date:   Tue, 7 Jun 2022 07:10:19 -1000
From:   Tejun Heo <tj@...nel.org>
To:     Wonhyuk Yang <vvghjk1234@...il.com>
Cc:     Steven Rostedt <rostedt@...dmis.org>,
        Ingo Molnar <mingo@...hat.com>,
        Baik Song An <bsahn@...i.re.kr>,
        Hong Yeon Kim <kimhy@...i.re.kr>,
        Taeung Song <taeung@...llinux.co.kr>, linuxgeek@...uxgeek.io,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] workqueue: Fix type of cpu in trace event

On Wed, May 04, 2022 at 11:32:03AM +0900, Wonhyuk Yang wrote:
> The trace event "workqueue_queue_work" use unsigned int type for
> req_cpu, cpu. This casue confusing cpu number like below log.
> 
> $ cat /sys/kernel/debug/tracing/trace
> cat-317  [001] ...: workqueue_queue_work: ... req_cpu=8192 cpu=4294967295
> 
> So, change unsigned type to signed type in the trace event. After
> applying this patch, cpu number will be printed as -1 instead of
> 4294967295 as folllows.
> 
> $ cat /sys/kernel/debug/tracing/trace
> cat-1338  [002] ...: workqueue_queue_work: ... req_cpu=8192 cpu=-1
> 
> Cc: Baik Song An <bsahn@...i.re.kr>
> Cc: Hong Yeon Kim <kimhy@...i.re.kr>
> Cc: Taeung Song <taeung@...llinux.co.kr>
> Cc: linuxgeek@...uxgeek.io
> Signed-off-by: Wonhyuk Yang <vvghjk1234@...il.com>

Applied to wq/for-5.19-fixes.

Thanks.

-- 
tejun