| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <202205271026.o40Lr8iX-lkp@intel.com>
Date: Fri, 27 May 2022 10:27:28 +0800
From: kernel test robot <lkp@...el.com>
To: Sean Christopherson <sean.j.christopherson@...el.com>
Cc: llvm@...ts.linux.dev, kbuild-all@...ts.01.org,
Mike Rapoport <rppt@...nel.org>, linux-kernel@...r.kernel.org,
Yang Weijiang <weijiang.yang@...el.com>,
Paolo Bonzini <pbonzini@...hat.com>
Subject: [rppt:cet/kvm 38/51] arch/x86/kvm/x86.c:6587:3: warning: unannotated
fall-through between switch labels
Hi Sean,
FYI, the error/warning still remains.
tree: https://git.kernel.org/pub/scm/linux/kernel/git/rppt/linux.git cet/kvm
head: 6c13d37e6c4ff3a7f86c5490b3d0f4f12d0a40da
commit: 6189c6f50e022a416cbd8620b5c17b0a88b6a0c7 [38/51] KVM: x86: Report XSS as an MSR to be saved if there are supported features
config: x86_64-randconfig-a014 (https://download.01.org/0day-ci/archive/20220527/202205271026.o40Lr8iX-lkp@intel.com/config)
compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project 6f4644d194da594562027a5d458d9fb7a20ebc39)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://git.kernel.org/pub/scm/linux/kernel/git/rppt/linux.git/commit/?id=6189c6f50e022a416cbd8620b5c17b0a88b6a0c7
git remote add rppt https://git.kernel.org/pub/scm/linux/kernel/git/rppt/linux.git
git fetch --no-tags rppt cet/kvm
git checkout 6189c6f50e022a416cbd8620b5c17b0a88b6a0c7
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash arch/x86/kvm/
If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@...el.com>
All warnings (new ones prefixed by >>):
>> arch/x86/kvm/x86.c:6587:3: warning: unannotated fall-through between switch labels [-Wimplicit-fallthrough]
case MSR_IA32_XSS:
^
arch/x86/kvm/x86.c:6587:3: note: insert '__attribute__((fallthrough));' to silence this warning
case MSR_IA32_XSS:
^
__attribute__((fallthrough));
arch/x86/kvm/x86.c:6587:3: note: insert 'break;' to avoid fall-through
case MSR_IA32_XSS:
^
break;
1 warning generated.
vim +6587 arch/x86/kvm/x86.c
6513
6514 static void kvm_init_msr_list(void)
6515 {
6516 struct x86_pmu_capability x86_pmu;
6517 u32 dummy[2];
6518 unsigned i;
6519
6520 BUILD_BUG_ON_MSG(INTEL_PMC_MAX_FIXED != 4,
6521 "Please update the fixed PMCs in msrs_to_saved_all[]");
6522
6523 perf_get_x86_pmu_capability(&x86_pmu);
6524
6525 num_msrs_to_save = 0;
6526 num_emulated_msrs = 0;
6527 num_msr_based_features = 0;
6528
6529 for (i = 0; i < ARRAY_SIZE(msrs_to_save_all); i++) {
6530 if (rdmsr_safe(msrs_to_save_all[i], &dummy[0], &dummy[1]) < 0)
6531 continue;
6532
6533 /*
6534 * Even MSRs that are valid in the host may not be exposed
6535 * to the guests in some cases.
6536 */
6537 switch (msrs_to_save_all[i]) {
6538 case MSR_IA32_BNDCFGS:
6539 if (!kvm_mpx_supported())
6540 continue;
6541 break;
6542 case MSR_TSC_AUX:
6543 if (!kvm_cpu_cap_has(X86_FEATURE_RDTSCP) &&
6544 !kvm_cpu_cap_has(X86_FEATURE_RDPID))
6545 continue;
6546 break;
6547 case MSR_IA32_UMWAIT_CONTROL:
6548 if (!kvm_cpu_cap_has(X86_FEATURE_WAITPKG))
6549 continue;
6550 break;
6551 case MSR_IA32_RTIT_CTL:
6552 case MSR_IA32_RTIT_STATUS:
6553 if (!kvm_cpu_cap_has(X86_FEATURE_INTEL_PT))
6554 continue;
6555 break;
6556 case MSR_IA32_RTIT_CR3_MATCH:
6557 if (!kvm_cpu_cap_has(X86_FEATURE_INTEL_PT) ||
6558 !intel_pt_validate_hw_cap(PT_CAP_cr3_filtering))
6559 continue;
6560 break;
6561 case MSR_IA32_RTIT_OUTPUT_BASE:
6562 case MSR_IA32_RTIT_OUTPUT_MASK:
6563 if (!kvm_cpu_cap_has(X86_FEATURE_INTEL_PT) ||
6564 (!intel_pt_validate_hw_cap(PT_CAP_topa_output) &&
6565 !intel_pt_validate_hw_cap(PT_CAP_single_range_output)))
6566 continue;
6567 break;
6568 case MSR_IA32_RTIT_ADDR0_A ... MSR_IA32_RTIT_ADDR3_B:
6569 if (!kvm_cpu_cap_has(X86_FEATURE_INTEL_PT) ||
6570 msrs_to_save_all[i] - MSR_IA32_RTIT_ADDR0_A >=
6571 intel_pt_validate_hw_cap(PT_CAP_num_address_ranges) * 2)
6572 continue;
6573 break;
6574 case MSR_ARCH_PERFMON_PERFCTR0 ... MSR_ARCH_PERFMON_PERFCTR0 + 17:
6575 if (msrs_to_save_all[i] - MSR_ARCH_PERFMON_PERFCTR0 >=
6576 min(INTEL_PMC_MAX_GENERIC, x86_pmu.num_counters_gp))
6577 continue;
6578 break;
6579 case MSR_ARCH_PERFMON_EVENTSEL0 ... MSR_ARCH_PERFMON_EVENTSEL0 + 17:
6580 if (msrs_to_save_all[i] - MSR_ARCH_PERFMON_EVENTSEL0 >=
6581 min(INTEL_PMC_MAX_GENERIC, x86_pmu.num_counters_gp))
6582 continue;
6583 break;
6584 case MSR_IA32_XFD:
6585 case MSR_IA32_XFD_ERR:
6586 if (!kvm_cpu_cap_has(X86_FEATURE_XFD))
> 6587 case MSR_IA32_XSS:
6588 if (!supported_xss)
6589 continue;
6590 break;
6591 default:
6592 break;
6593 }
6594
6595 msrs_to_save[num_msrs_to_save++] = msrs_to_save_all[i];
6596 }
6597
6598 for (i = 0; i < ARRAY_SIZE(emulated_msrs_all); i++) {
6599 if (!static_call(kvm_x86_has_emulated_msr)(NULL, emulated_msrs_all[i]))
6600 continue;
6601
6602 emulated_msrs[num_emulated_msrs++] = emulated_msrs_all[i];
6603 }
6604
6605 for (i = 0; i < ARRAY_SIZE(msr_based_features_all); i++) {
6606 struct kvm_msr_entry msr;
6607
6608 msr.index = msr_based_features_all[i];
6609 if (kvm_get_msr_feature(&msr))
6610 continue;
6611
6612 msr_based_features[num_msr_based_features++] = msr_based_features_all[i];
6613 }
6614 }
6615
--
0-DAY CI Kernel Test Service
https://01.org/lkp
Powered by blists - more mailing lists