linux-kernel - Re: [PATCH] virtio_balloon: check virtqueue_add

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <4789cbbb9d59420abc86a9e225ef0bfd@inspur.com>
Date:   Fri, 27 May 2022 10:43:30 +0000
From:   Bo Liu (刘波)-浪潮信息 <liubo03@...pur.com>
To:     "mst@...hat.com" <mst@...hat.com>
CC:     "david@...hat.com" <david@...hat.com>,
        "jasowang@...hat.com" <jasowang@...hat.com>,
        "virtualization@...ts.linux-foundation.org" 
        <virtualization@...ts.linux-foundation.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] virtio_balloon: check virtqueue_add_outbuf() return value

The purpose of this patch is, virtqueue_add_outbuf() adding data to
virtqueue may succeed or fail. If successful, it will call virtqueue_kick()
to notifie the host backend driver, but if the virtqueue_add_outbuf() fails,
the data is not successfully added to the virtqueue, and the host back-end
driver does not need to be notified for processing.

Thanks.

-----邮件原件-----
发件人: Michael S. Tsirkin <mst@...hat.com> 
发送时间: 2022年5月27日 18:25
收件人: Bo Liu (刘波)-浪潮信息 <liubo03@...pur.com>
抄送: david@...hat.com; jasowang@...hat.com;
virtualization@...ts.linux-foundation.org; linux-kernel@...r.kernel.org
主题: Re: [PATCH] virtio_balloon: check virtqueue_add_outbuf() return value

On Thu, May 26, 2022 at 09:34:01PM -0400, Bo Liu wrote:
> virtqueue_add_outbuf() can fail, when it fails, there is no need to 
> call the funciont virtqueue_kick().
> Signed-off-by: Bo Liu <liubo03@...pur.com>

Sorry don't get it.
What's the point of this patch really?

> ---
>  drivers/virtio/virtio_balloon.c | 18 +++++++++++-------
>  1 file changed, 11 insertions(+), 7 deletions(-)
> 
> diff --git a/drivers/virtio/virtio_balloon.c 
> b/drivers/virtio/virtio_balloon.c index b9737da6c4dd..0d7da4d95e1e 
> 100644
> --- a/drivers/virtio/virtio_balloon.c
> +++ b/drivers/virtio/virtio_balloon.c
> @@ -153,16 +153,18 @@ static void tell_host(struct virtio_balloon *vb, 
> struct virtqueue *vq)  {
>  	struct scatterlist sg;
>  	unsigned int len;
> +	int err;
>  
>  	sg_init_one(&sg, vb->pfns, sizeof(vb->pfns[0]) * vb->num_pfns);
>  
>  	/* We should always be able to add one buffer to an empty queue. */
> -	virtqueue_add_outbuf(vq, &sg, 1, vb, GFP_KERNEL);
> -	virtqueue_kick(vq);
> -
> -	/* When host has read buffer, this completes via balloon_ack */
> -	wait_event(vb->acked, virtqueue_get_buf(vq, &len));
> +	err = virtqueue_add_outbuf(vq, &sg, 1, vb, GFP_KERNEL);
> +	if (!err) {
> +		virtqueue_kick(vq);
>  
> +		/* When host has read buffer, this completes via balloon_ack
*/
> +		wait_event(vb->acked, virtqueue_get_buf(vq, &len));
> +	}
>  }
>  
>  static int virtballoon_free_page_report(struct 
> page_reporting_dev_info *pr_dev_info, @@ -382,6 +384,7 @@ static void
stats_handle_request(struct virtio_balloon *vb)
>  	struct virtqueue *vq;
>  	struct scatterlist sg;
>  	unsigned int len, num_stats;
> +	int err;
>  
>  	num_stats = update_balloon_stats(vb);
>  
> @@ -389,8 +392,9 @@ static void stats_handle_request(struct virtio_balloon
*vb)
>  	if (!virtqueue_get_buf(vq, &len))
>  		return;
>  	sg_init_one(&sg, vb->stats, sizeof(vb->stats[0]) * num_stats);
> -	virtqueue_add_outbuf(vq, &sg, 1, vb, GFP_KERNEL);
> -	virtqueue_kick(vq);
> +	err = virtqueue_add_outbuf(vq, &sg, 1, vb, GFP_KERNEL);
> +	if (!err)
> +		virtqueue_kick(vq);
>  }
>  
>  static inline s64 towards_target(struct virtio_balloon *vb)
> --
> 2.27.0


Download attachment "smime.p7s" of type "application/pkcs7-signature" (3777 bytes)