linux-kernel - Re: [PATCH] virtio_balloon: check virtqueue_add

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20220527065611-mutt-send-email-mst@kernel.org>
Date:   Fri, 27 May 2022 06:57:32 -0400
From:   "Michael S. Tsirkin" <mst@...hat.com>
To:     Bo Liu (刘波)-浪潮信息 
        <liubo03@...pur.com>
Cc:     "david@...hat.com" <david@...hat.com>,
        "jasowang@...hat.com" <jasowang@...hat.com>,
        "virtualization@...ts.linux-foundation.org" 
        <virtualization@...ts.linux-foundation.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] virtio_balloon: check virtqueue_add_outbuf() return value

On Fri, May 27, 2022 at 10:43:30AM +0000, Bo Liu (刘波)-浪潮信息 wrote:
> The purpose of this patch is, virtqueue_add_outbuf() adding data to
> virtqueue may succeed or fail. If successful, it will call virtqueue_kick()
> to notifie the host backend driver, but if the virtqueue_add_outbuf() fails,
> the data is not successfully added to the virtqueue, and the host back-end
> driver does not need to be notified for processing.
> 
> Thanks.

Why is it a problem if we do?

-- 
MST