linux-kernel - Re: [PATCH] csky/kprobe: reclaim insn

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAJF2gTTW6qpBWw2tEHg+WLywRnAR2G5gqRoYF_inzzS_tEUz=A@mail.gmail.com>
Date:   Fri, 27 May 2022 10:53:36 +0800
From:   Guo Ren <guoren@...nel.org>
To:     Masami Hiramatsu <mhiramat@...nel.org>
Cc:     Liao Chang <liaochang1@...wei.com>,
        Steven Rostedt <rostedt@...dmis.org>,
        Peter Zijlstra <peterz@...radead.org>,
        kbuild test robot <lkp@...el.com>,
        Naveen Rao <naveen.n.rao@...ux.vnet.ibm.com>,
        jszhang@...nel.org, linux-csky@...r.kernel.org,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] csky/kprobe: reclaim insn_slot on kprobe unregistration

On Thu, May 26, 2022 at 11:30 PM Masami Hiramatsu <mhiramat@...nel.org> wrote:
>
> On Wed, 25 May 2022 16:02:41 +0800
> Liao Chang <liaochang1@...wei.com> wrote:
>
> > On kprobe registration kernel allocate one insn_slot for new kprobe,
> > but it forget to reclaim the insn_slot on unregistration, leading to a
> > potential leakage.
> >
> > Reported-by: Chen Guokai <chenguokai17@...ls.ucas.ac.cn>
> > Signed-off-by: Liao Chang <liaochang1@...wei.com>
>
> This looks good to me too. I think this should go through csky tree.
Okay, I would add the Fix line and put it into Linux-5.19-rc2.

>
> Reviewed-by: Masami Hiramatsu (Google) <mhiramat@...nel.org>
>
> Thank you,
>
>
> > ---
> >  arch/csky/kernel/probes/kprobes.c | 4 ++++
> >  1 file changed, 4 insertions(+)
> >
> > diff --git a/arch/csky/kernel/probes/kprobes.c b/arch/csky/kernel/probes/kprobes.c
> > index 42920f25e73c..661da54b418f 100644
> > --- a/arch/csky/kernel/probes/kprobes.c
> > +++ b/arch/csky/kernel/probes/kprobes.c
> > @@ -124,6 +124,10 @@ void __kprobes arch_disarm_kprobe(struct kprobe *p)
> >
> >  void __kprobes arch_remove_kprobe(struct kprobe *p)
> >  {
> > +     if (p->ainsn.api.insn) {
> > +             free_insn_slot(p->ainsn.api.insn, 0);
> > +             p->ainsn.api.insn = NULL;
> > +     }
> >  }
> >
> >  static void __kprobes save_previous_kprobe(struct kprobe_ctlblk *kcb)
> > --
> > 2.17.1
> >
>
>
> --
> Masami Hiramatsu (Google) <mhiramat@...nel.org>



-- 
Best Regards
 Guo Ren

ML: https://lore.kernel.org/linux-csky/