linux-kernel - Re: [PATCH] m68k: coldfire:Add const to clk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMuHMdVk+RStP90cmuWzAY+3tLEJwaaOPR-h=xrLahmCZ_CDOg@mail.gmail.com>
Date:   Mon, 30 May 2022 09:11:54 +0200
From:   Geert Uytterhoeven <geert@...ux-m68k.org>
To:     Xiang wangx <wangxiang@...rlc.com>
Cc:     Greg Ungerer <gerg@...ux-m68k.org>,
        linux-m68k <linux-m68k@...ts.linux-m68k.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] m68k: coldfire:Add const to clk_ops

Hi Xiang,

On Mon, May 30, 2022 at 4:53 AM Xiang wangx <wangxiang@...rlc.com> wrote:
> Struct clk_ops should normally be const.
>
> Signed-off-by: Xiang wangx <wangxiang@...rlc.com>

Thanks for your patch!

> --- a/arch/m68k/coldfire/clk.c
> +++ b/arch/m68k/coldfire/clk.c
> @@ -50,7 +50,7 @@ static void __clk_disable0(struct clk *clk)
>         __raw_writeb(clk->slot, MCFPM_PPMSR0);
>  }
>
> -struct clk_ops clk_ops0 = {
> +struct const clk_ops clk_ops0 = {

The "const" should be first on the line.
Please test-compile your patches before submitting them.

>         .enable         = __clk_enable0,
>         .disable        = __clk_disable0,
>  };

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds