linux-kernel - Re: [PATCH] m68k: coldfire:Add const to clk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 31 May 2022 21:13:52 +0800
From:   kernel test robot <lkp@...el.com>
To:     Xiang wangx <wangxiang@...rlc.com>, gerg@...ux-m68k.org
Cc:     kbuild-all@...ts.01.org, geert@...ux-m68k.org,
        linux-m68k@...ts.linux-m68k.org, linux-kernel@...r.kernel.org,
        Xiang wangx <wangxiang@...rlc.com>
Subject: Re: [PATCH] m68k: coldfire:Add const to clk_ops

Hi Xiang,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on gerg-m68knommu/for-next]
[also build test ERROR on geert-m68k/for-next v5.18 next-20220531]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/intel-lab-lkp/linux/commits/Xiang-wangx/m68k-coldfire-Add-const-to-clk_ops/20220530-105531
base:   https://git.kernel.org/pub/scm/linux/kernel/git/gerg/m68knommu.git for-next
config: m68k-allnoconfig (https://download.01.org/0day-ci/archive/20220531/202205312132.iaViCBtV-lkp@intel.com/config)
compiler: m68k-linux-gcc (GCC) 11.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/intel-lab-lkp/linux/commit/e44f3b73f214f99802c9a010145922eb0a126933
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Xiang-wangx/m68k-coldfire-Add-const-to-clk_ops/20220530-105531
        git checkout e44f3b73f214f99802c9a010145922eb0a126933
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.3.0 make.cross W=1 O=build_dir ARCH=m68k SHELL=/bin/bash arch/m68k/coldfire/

If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@...el.com>

All errors (new ones prefixed by >>):

>> arch/m68k/coldfire/clk.c:53:8: error: expected '{' before 'const'
      53 | struct const clk_ops clk_ops0 = {
         |        ^~~~~
   arch/m68k/coldfire/clk.c:48:13: warning: '__clk_disable0' defined but not used [-Wunused-function]
      48 | static void __clk_disable0(struct clk *clk)
         |             ^~~~~~~~~~~~~~
   arch/m68k/coldfire/clk.c:43:13: warning: '__clk_enable0' defined but not used [-Wunused-function]
      43 | static void __clk_enable0(struct clk *clk)
         |             ^~~~~~~~~~~~~


vim +53 arch/m68k/coldfire/clk.c

    52	
  > 53	struct const clk_ops clk_ops0 = {
    54		.enable		= __clk_enable0,
    55		.disable	= __clk_disable0,
    56	};
    57	

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp