linux-kernel - Re: [PATCH v10 15/19] KVM: s390: pv: asynchronous destroy for reboot

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220530130621.5256a0b1@p-imbrenda>
Date:   Mon, 30 May 2022 13:06:21 +0200
From:   Claudio Imbrenda <imbrenda@...ux.ibm.com>
To:     Nico Boehr <nrb@...ux.ibm.com>
Cc:     kvm@...r.kernel.org, borntraeger@...ibm.com, frankja@...ux.ibm.com,
        thuth@...hat.com, pasic@...ux.ibm.com, david@...hat.com,
        linux-s390@...r.kernel.org, linux-kernel@...r.kernel.org,
        scgl@...ux.ibm.com, mimu@...ux.ibm.com
Subject: Re: [PATCH v10 15/19] KVM: s390: pv: asynchronous destroy for
 reboot

On Mon, 30 May 2022 11:46:26 +0200
Nico Boehr <nrb@...ux.ibm.com> wrote:

> On Thu, 2022-04-14 at 10:03 +0200, Claudio Imbrenda wrote:
> [...]
> > diff --git a/arch/s390/kvm/pv.c b/arch/s390/kvm/pv.c
> > index b20f2cbd43d9..36bc107bbd7d 100644
> > --- a/arch/s390/kvm/pv.c
> > +++ b/arch/s390/kvm/pv.c  
> [...]
> > +/**
> > + * kvm_s390_pv_deinit_vm_async - Perform an asynchronous teardown of
> > a
> > + * protected VM.
> > + * @kvm the VM previously associated with the protected VM
> > + * @rc return value for the RC field of the UVCB
> > + * @rrc return value for the RRC field of the UVCB
> > + *
> > + * Tear down the protected VM that had previously been set aside
> > using
> > + * kvm_s390_pv_deinit_vm_async_prepare.
> > + *
> > + * Context: kvm->lock needs to be held  
> 
> ...and will be released...

no, I decided to refactor this so that the lock won't be held at
all when not needed (you'll see in the next respin), should be cleaner

> 
> > + *
> > + * Return: 0 in case of success, -EINVAL if no protected VM had been
> > + * prepared for asynchronous teardowm, -EIO in case of other errors.
> > + */
> > +int kvm_s390_pv_deinit_vm_async(struct kvm *kvm, u16 *rc, u16 *rrc)  
> 
> Do you also want to set rc and rrc as in kvm_s390_pv_deinit_vm_async_prepare()?

oh... no I don't

I should propagate the actual RC and RRC from the UVC, which I'm not
doing (will fix)