linux-kernel - Re: [PATCH v10 04/19] KVM: s390: pv: refactor s390_reset

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220530125009.6107ae54@p-imbrenda>
Date:   Mon, 30 May 2022 12:50:09 +0200
From:   Claudio Imbrenda <imbrenda@...ux.ibm.com>
To:     Nico Boehr <nrb@...ux.ibm.com>
Cc:     kvm@...r.kernel.org, borntraeger@...ibm.com, frankja@...ux.ibm.com,
        thuth@...hat.com, pasic@...ux.ibm.com, david@...hat.com,
        linux-s390@...r.kernel.org, linux-kernel@...r.kernel.org,
        scgl@...ux.ibm.com, mimu@...ux.ibm.com
Subject: Re: [PATCH v10 04/19] KVM: s390: pv: refactor s390_reset_acc

On Mon, 30 May 2022 09:40:43 +0200
Nico Boehr <nrb@...ux.ibm.com> wrote:

> On Mon, 2022-05-16 at 18:11 +0200, Claudio Imbrenda wrote:
> [...]
> > > [...]  
> > > > diff --git a/arch/s390/mm/gmap.c b/arch/s390/mm/gmap.c
> > > > index e8904cb9dc38..a3a1f90f6ec1 100644
> > > > --- a/arch/s390/mm/gmap.c
> > > > +++ b/arch/s390/mm/gmap.c
> > > > @@ -2676,44 +2676,81 @@ void s390_reset_cmma(struct mm_struct
> > > > *mm)
> > > >  }
> > > >  EXPORT_SYMBOL_GPL(s390_reset_cmma);
> > > >  
> > > > -/*
> > > > - * make inaccessible pages accessible again
> > > > - */
> > > > -static int __s390_reset_acc(pte_t *ptep, unsigned long addr,
> > > > -                           unsigned long next, struct mm_walk
> > > > *walk)
> > > > +#define DESTROY_LOOP_THRESHOLD 32    
> > > 
> > > maybe GATHER_NUM_PAGE_REFS_TO_TAKE?  
> > 
> > what about GATHER_GET_PAGES ?  
> 
> Yes, that's good as well.

will be fixed