linux-kernel - Re: [PATCH v1 1/2] dt-bindings: pinctrl: mt8192: Add drive-strength-microamp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220531211616.vq73g6r4vrxxahqe@notapiano>
Date:   Tue, 31 May 2022 17:16:16 -0400
From:   Nícolas F. R. A. Prado 
        <nfraprado@...labora.com>
To:     Chen-Yu Tsai <wenst@...omium.org>
Cc:     Linus Walleij <linus.walleij@...aro.org>, kernel@...labora.com,
        AngeloGioacchino Del Regno 
        <angelogioacchino.delregno@...labora.com>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Matthias Brugger <matthias.bgg@...il.com>,
        Rob Herring <robh+dt@...nel.org>,
        Sean Wang <sean.wang@...iatek.com>, devicetree@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org, linux-gpio@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-mediatek@...ts.infradead.org
Subject: Re: [PATCH v1 1/2] dt-bindings: pinctrl: mt8192: Add
 drive-strength-microamp

On Mon, May 30, 2022 at 04:48:51PM +0800, Chen-Yu Tsai wrote:
> On Wed, May 25, 2022 at 11:58 PM Nícolas F. R. A. Prado
> <nfraprado@...labora.com> wrote:
> >
> > Commit e5fabbe43f3f ("pinctrl: mediatek: paris: Support generic
> > PIN_CONFIG_DRIVE_STRENGTH_UA") added support for using
> > drive-strength-microamp instead of mediatek,drive-strength-adv.
> >
> > Since there aren't any users of mediatek,drive-strength-adv on mt8192
> > yet, remove this property and add drive-strength-microamp in its place,
> > which has a clearer meaning.
> 
> Cool! Thanks for taking care of this~ I was looking at this and tried
> to make drive-strength and drive-strength-microamp mutually exclusive,
> but since they are optional, it didn't really work, and I put it on the
> back burner.

I didn't think of enforcing the properties to be mutually exclusive in the
dt-binding, but that is indeed a good idea. After a bit of head-scratching seems
like it is possible although unintuitive (by using 'required' inside the if
block). I'll send a v2 with this restriction added, and the same thing for patch
2, since bias-pull-up/down also shouldn't be used together with bias-disable.

Thanks,
Nícolas

> 
> 
> ChenYu