linux-kernel - Re: [PATCH v1 1/3] iio: adc: meson_saradc: Convert to use dev_err

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 31 May 2022 23:53:27 +0200
From:   Martin Blumenstingl <martin.blumenstingl@...glemail.com>
To:     Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc:     linux-iio@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-amlogic@...ts.infradead.org, linux-kernel@...r.kernel.org,
        Jonathan Cameron <jic23@...nel.org>,
        Lars-Peter Clausen <lars@...afoo.de>,
        Neil Armstrong <narmstrong@...libre.com>,
        Kevin Hilman <khilman@...libre.com>,
        Jerome Brunet <jbrunet@...libre.com>
Subject: Re: [PATCH v1 1/3] iio: adc: meson_saradc: Convert to use dev_err_probe()

Hi Andy,

overall this is looking great - thank you for this patch!

On Tue, May 31, 2022 at 11:18 PM Andy Shevchenko
<andriy.shevchenko@...ux.intel.com> wrote:
[...]
> +       if (IS_ERR(priv->tsc_regmap))
> +               return dev_err_probe(dev, PTR_ERR(priv->tsc_regmap), "failed to get amlogic,hhi-sysctrl regmap\n");
checkpatch complains:
  WARNING: line length of 115 exceeds 100 columns
  #44: FILE: drivers/iio/adc/meson_saradc.c:728:

Adding a line-break right before the error message will solve this problem


Best regards,
Martin