linux-kernel - Re: [PATCH v5 1/4] dt-bindings: nand: meson: fix meson nfc clock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20220601195104.GA320194-robh@kernel.org>
Date:   Wed, 1 Jun 2022 14:51:04 -0500
From:   Rob Herring <robh@...nel.org>
To:     Liang Yang <liang.yang@...ogic.com>
Cc:     Miquel Raynal <miquel.raynal@...tlin.com>,
        linux-arm-kernel@...ts.infradead.org,
        XianWei Zhao <xianwei.zhao@...ogic.com>,
        Jerome Brunet <jbrunet@...libre.com>,
        YongHui Yu <yonghui.yu@...ogic.com>,
        Richard Weinberger <richard@....at>,
        Rob Herring <robh+dt@...nel.org>, devicetree@...r.kernel.org,
        Kevin Hilman <khilman@...libre.com>,
        linux-kernel@...r.kernel.org,
        Neil Armstrong <narmstrong@...libre.com>,
        Martin Blumenstingl <martin.blumenstingl@...glemail.com>,
        linux-amlogic@...ts.infradead.org,
        Jianxin Pan <jianxin.pan@...ogic.com>,
        Victor Wan <victor.wan@...ogic.com>,
        BiChao Zheng <bichao.zheng@...ogic.com>,
        Vignesh Raghavendra <vigneshr@...com>,
        linux-mtd@...ts.infradead.org,
        Kelvin Zhang <kelvin.zhang@...ogic.com>
Subject: Re: [PATCH v5 1/4] dt-bindings: nand: meson: fix meson nfc clock

On Fri, 13 May 2022 20:34:01 +0800, Liang Yang wrote:
> EMMC and NAND have the same clock control register named 'SD_EMMC_CLOCK'
> which is defined in EMMC port internally. bit0~5 of 'SD_EMMC_CLOCK' is
> the divider and bit6~7 is the mux for fix pll and xtal. At the beginning,
> a common MMC and NAND sub-clock was discussed and planed to be implemented
> as NFC clock provider, but now this series of patches of a common MMC and
> NAND sub-clock are never being accepted and the current binding was never
> valid. the reasons are:
> 1. EMMC and NAND, which are mutually exclusive anyway
> 2. coupling the EMMC and NAND.
> 3. it seems that a common MMC and NAND sub-clock is over engineered.
> and let us see the link for more information:
> https://lore.kernel.org/all/20220121074508.42168-5-liang.yang@amlogic.com
> so The meson nfc can't work now, let us rework the clock.
> 
> Signed-off-by: Liang Yang <liang.yang@...ogic.com>
> ---
>  .../bindings/mtd/amlogic,meson-nand.txt       | 29 ++++++++-----------
>  1 file changed, 12 insertions(+), 17 deletions(-)
> 

Acked-by: Rob Herring <robh@...nel.org>