linux-kernel - Re: [PATCH v2] iio: Use octal permissions and DEVICE_ATTR

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Ype2tDgWRVC68O//@spruce>
Date:   Wed, 1 Jun 2022 14:57:56 -0400
From:   Joe Simmons-Talbott <joetalbott@...il.com>
To:     Andy Shevchenko <andy.shevchenko@...il.com>
Cc:     Jonathan Cameron <jic23@...nel.org>,
        linux-iio <linux-iio@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Joe Perches <joe@...ches.com>
Subject: Re: [PATCH v2] iio: Use octal permissions and DEVICE_ATTR_{RO,RW}.

On Wed, Jun 01, 2022 at 12:01:12PM +0200, Andy Shevchenko wrote:
> On Tue, May 31, 2022 at 9:40 PM Joe Simmons-Talbott
> <joetalbott@...il.com> wrote:
> >
> > As reported by checkpatch.pl.  Where possible use DEVICE_ATTR_RO and
> 
> DEVICE_ATTR_RO()
> 
> > DEVICE_ATTR_RW.  Change function names to be <var>_show() for read and
> 
> DEVICE_ATTR_RW()
> 
> > <var>_store() for write.
> 
> ...
> 
> >  static struct device_attribute dev_attr_length_ro = __ATTR(length,
> > +       0444, length_show, NULL);
> 
> >  static struct device_attribute dev_attr_watermark_ro = __ATTR(watermark,
> > +       0444, watermark_show, NULL);
> 
> Why not __ATTR_RO() here?

Thank you for reviewing.  An updated v3 patch has been sent.

Thanks,
Joe
> 
> -- 
> With Best Regards,
> Andy Shevchenko