linux-kernel - Re: [PATCH 2/4] mm/shmem: return -EINVAL for addr not PAGE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e25a6d7b-c93f-c680-5044-c9dac1aa0a2f@redhat.com>
Date:   Wed, 1 Jun 2022 16:14:46 +0200
From:   David Hildenbrand <david@...hat.com>
To:     Chen Wandun <chenwandun@...wei.com>, hughd@...gle.com,
        akpm@...ux-foundation.org, linux-mm@...ck.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/4] mm/shmem: return -EINVAL for addr not PAGE_SIZE
 aligned

On 01.06.22 15:37, David Hildenbrand wrote:
> On 01.06.22 14:44, Chen Wandun wrote:
>> If addr is not PAGE_SIZE aligned, return -EINVAL directly.
> 
> Why is this one to be treated in a special way compared to all of the
> other related checks?

Ah, I see you modify other places in other patches. Maybe just combine
all these return value changes into a single patch? That makes it look
less "special".



-- 
Thanks,

David / dhildenb