linux-kernel - Re: [PATCH 2/4] mm/shmem: return -EINVAL for addr not PAGE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <374dfbbd-415e-890e-15db-b36c34a70a8d@huawei.com>
Date:   Sun, 5 Jun 2022 10:05:35 +0800
From:   Chen Wandun <chenwandun@...wei.com>
To:     David Hildenbrand <david@...hat.com>, <hughd@...gle.com>,
        <akpm@...ux-foundation.org>, <linux-mm@...ck.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 2/4] mm/shmem: return -EINVAL for addr not PAGE_SIZE
 aligned



On 2022/6/1 22:14, David Hildenbrand wrote:
> On 01.06.22 15:37, David Hildenbrand wrote:
>> On 01.06.22 14:44, Chen Wandun wrote:
>>> If addr is not PAGE_SIZE aligned, return -EINVAL directly.
>> Why is this one to be treated in a special way compared to all of the
>> other related checks?
> Ah, I see you modify other places in other patches. Maybe just combine
> all these return value changes into a single patch? That makes it look
> less "special".
OK, patch 2 and patch 3 are used to return error value directly, I will 
combine these patch
to a single patch in next version.

Thanks.
>
>
>