linux-kernel - Re: [PATCH v3] average: Clarify the restrictions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 1 Jun 2022 21:41:54 -0700
From:   Randy Dunlap <rdunlap@...radead.org>
To:     Jui-Tse Huang <juitse.huang@...il.com>,
        linux-kernel@...r.kernel.org
Cc:     Mark Rutland <mark.rutland@....com>,
        Johannes Berg <johannes.berg@...el.com>,
        Bruno Randolf <br1@...fach.org>,
        Ching-Chun Huang <jserv@...s.ncku.edu.tw>
Subject: Re: [PATCH v3] average: Clarify the restrictions



On 6/1/22 18:45, Jui-Tse Huang wrote:
> There is several restrictions in the EWMA helper macro that the
> developers should take care of, but the comment does not mentioned yet,
> thus, this patch clarify the restrictions.
> 
> Signed-off-by: Jui-Tse Huang <juitse.huang@...il.com>
> ---
> 
> Notes:
>     v3: fix typo (Randy Dunlap)
>     v2: fix spelling and wording (Bruno Randolf)

Acked-by: Randy Dunlap <rdunlap@...radead.org>

Thanks.

> 
>  include/linux/average.h | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/include/linux/average.h b/include/linux/average.h
> index a1a8f09631ce..9c3c8b5b518e 100644
> --- a/include/linux/average.h
> +++ b/include/linux/average.h
> @@ -11,7 +11,10 @@
>   *
>   * This implements a fixed-precision EWMA algorithm, with both the
>   * precision and fall-off coefficient determined at compile-time
> - * and built into the generated helper funtions.
> + * and built into the generated helper functions.
> + *
> + * This implementation supports up to 30 bits of precision, and only
> + * the API for fetching non-fractional part is provided for now.
>   *
>   * The first argument to the macro is the name that will be used
>   * for the struct and helper functions.

-- 
~Randy