[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CANubcdVNEsJvGz+gpJjvF14_D_+K9Xv5UtQJdf9s1o07ghFY1A@mail.gmail.com>
Date: Thu, 2 Jun 2022 14:23:43 +0800
From: Stephen Zhang <starzhangzsd@...il.com>
To: linux@...inikbrodowski.net, Jonathan.Cameron@...wei.com,
broonie@...nel.org, arnd@...db.de, lukas.bulwahn@...il.com,
daniel@...que.org
Cc: zhangshida <zhangshida@...inos.cn>, linux-kernel@...r.kernel.org,
k2ci <kernel-bot@...inos.cn>
Subject: Re: [PATCH v3] pcmcia: add MIPS_DB1XXX dependence
ping
Stephen Zhang <starzhangzsd@...il.com> 于2022年5月10日周二 10:33写道:
>
> From: Shida Zhang <zhangshida@...inos.cn>
>
> drivers/pcmcia/db1xxx_ss.c uses the bcsr_xxxx() from
> arch/mips/alchemy/devboards/bcsr.c, which causes a link
> error:
>
> drivers/pcmcia/db1xxx_ss.c:(.text+0x2b4): undefined reference to `bcsr_read'
> mips-linux-gnu-ld: ../drivers/pcmcia/db1xxx_ss.c:(.text+0x2fc): undefined reference to `bcsr_read'
> drivers/pcmcia/db1xxx_ss.c:(.text+0x374): undefined reference to `bcsr_read'
> mips-linux-gnu-ld: ../drivers/pcmcia/db1xxx_ss.c:(.text+0x380): undefined reference to `bcsr_read'
> drivers/pcmcia/db1xxx_ss.c:(.text+0x534): undefined reference to `bcsr_read'
> drivers/pcmcia/db1xxx_ss.c:(.text+0xcc8): undefined reference to `bcsr_mod'
>
>
> So add MIPS_DB1XXX dependence.
>
> Reported-by: k2ci <kernel-bot@...inos.cn>
> Signed-off-by: Shida Zhang <zhangshida@...inos.cn>
> Acked-by: Arnd Bergmann <arnd@...db.de>
> ---
> Changes from v1:
> - Rewrite the commit message.
> Changes from v2:
> - Give credit to k2ci for reporting the issue.
> ---
> drivers/pcmcia/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pcmcia/Kconfig b/drivers/pcmcia/Kconfig
> index 2ce261cfff8e..04b51cb67fbf 100644
> --- a/drivers/pcmcia/Kconfig
> +++ b/drivers/pcmcia/Kconfig
> @@ -151,7 +151,7 @@ config TCIC
>
> config PCMCIA_ALCHEMY_DEVBOARD
> tristate "Alchemy Db/Pb1xxx PCMCIA socket services"
> - depends on MIPS_ALCHEMY && PCMCIA
> + depends on MIPS_ALCHEMY && MIPS_DB1XXX && PCMCIA
> help
> Enable this driver of you want PCMCIA support on your Alchemy
> Db1000, Db/Pb1100, Db/Pb1500, Db/Pb1550, Db/Pb1200, DB1300
> --
> 2.30.2
>
Powered by blists - more mailing lists