linux-kernel - Re: [PATCH v3] pcmcia: add MIPS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YphiRHtC0TaxNDDY@owl.dominikbrodowski.net>
Date:   Thu, 2 Jun 2022 09:09:56 +0200
From:   Dominik Brodowski <linux@...inikbrodowski.net>
To:     Stephen Zhang <starzhangzsd@...il.com>
Cc:     Jonathan.Cameron@...wei.com, broonie@...nel.org, arnd@...db.de,
        lukas.bulwahn@...il.com, daniel@...que.org,
        zhangshida <zhangshida@...inos.cn>, linux-kernel@...r.kernel.org,
        k2ci <kernel-bot@...inos.cn>
Subject: Re: [PATCH v3] pcmcia: add MIPS_DB1XXX dependence

A different variant is upstream now, see

	https://git.kernel.org/torvalds/c/2380dd691e1fe1ebe3f346d0ce54f8fc7eacc167

Thanks,
	Dominik

Am Thu, Jun 02, 2022 at 02:23:43PM +0800 schrieb Stephen Zhang:
> ping
> 
> Stephen Zhang <starzhangzsd@...il.com> 于2022年5月10日周二 10:33写道：
> >
> > From: Shida Zhang <zhangshida@...inos.cn>
> >
> > drivers/pcmcia/db1xxx_ss.c uses the bcsr_xxxx() from
> > arch/mips/alchemy/devboards/bcsr.c, which causes a link
> > error:
> >
> > drivers/pcmcia/db1xxx_ss.c:(.text+0x2b4): undefined reference to `bcsr_read'
> > mips-linux-gnu-ld: ../drivers/pcmcia/db1xxx_ss.c:(.text+0x2fc): undefined reference to `bcsr_read'
> > drivers/pcmcia/db1xxx_ss.c:(.text+0x374): undefined reference to `bcsr_read'
> > mips-linux-gnu-ld: ../drivers/pcmcia/db1xxx_ss.c:(.text+0x380): undefined reference to `bcsr_read'
> > drivers/pcmcia/db1xxx_ss.c:(.text+0x534): undefined reference to `bcsr_read'
> > drivers/pcmcia/db1xxx_ss.c:(.text+0xcc8): undefined reference to `bcsr_mod'
> >
> >
> > So add MIPS_DB1XXX dependence.
> >
> > Reported-by: k2ci <kernel-bot@...inos.cn>
> > Signed-off-by: Shida Zhang <zhangshida@...inos.cn>
> > Acked-by: Arnd Bergmann <arnd@...db.de>
> > ---
> > Changes from v1:
> > - Rewrite the commit message.
> > Changes from v2:
> > - Give credit to k2ci for reporting the issue.
> > ---
> >  drivers/pcmcia/Kconfig | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/pcmcia/Kconfig b/drivers/pcmcia/Kconfig
> > index 2ce261cfff8e..04b51cb67fbf 100644
> > --- a/drivers/pcmcia/Kconfig
> > +++ b/drivers/pcmcia/Kconfig
> > @@ -151,7 +151,7 @@ config TCIC
> >
> >  config PCMCIA_ALCHEMY_DEVBOARD
> >         tristate "Alchemy Db/Pb1xxx PCMCIA socket services"
> > -       depends on MIPS_ALCHEMY && PCMCIA
> > +       depends on MIPS_ALCHEMY && MIPS_DB1XXX && PCMCIA
> >         help
> >           Enable this driver of you want PCMCIA support on your Alchemy
> >           Db1000, Db/Pb1100, Db/Pb1500, Db/Pb1550, Db/Pb1200, DB1300
> > --
> > 2.30.2
> >