[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <7e1ddcb4-8e89-e7cf-3abf-b6dfba09102c@nvidia.com>
Date: Thu, 2 Jun 2022 17:04:13 +0530
From: Vidya Sagar <vidyas@...dia.com>
To: Miaoqian Lin <linmq006@...il.com>,
Lorenzo Pieralisi <lorenzo.pieralisi@....com>,
Rob Herring <robh@...nel.org>,
Krzysztof WilczyĆski <kw@...ux.com>,
Bjorn Helgaas <bhelgaas@...gle.com>,
Thierry Reding <thierry.reding@...il.com>,
Jonathan Hunter <jonathanh@...dia.com>,
Om Prakash Singh <omp@...dia.com>,
Fan Fei <ffclaire1224@...il.com>, linux-pci@...r.kernel.org,
linux-tegra@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] PCI: tegra194: Fix PM error handling in
tegra_pcie_config_ep
Thanks for pushing the change.
Reviewed-by: Vidya Sagar <vidyas@...dia.com>
On 6/2/2022 8:49 AM, Miaoqian Lin wrote:
> External email: Use caution opening links or attachments
>
>
> The pm_runtime_enable() will increase power disable depth.
> if dw_pcie_ep_init() fails, we should use pm_runtime_disable()
> to balance it pm_runtime_enable().
> Add missing pm_runtime_disable() for tegra_pcie_config_ep()
>
> Fixes: c57247f940e8 ("PCI: tegra: Add support for PCIe endpoint mode in Tegra194")
> Signed-off-by: Miaoqian Lin <linmq006@...il.com>
> ---
> drivers/pci/controller/dwc/pcie-tegra194.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/pci/controller/dwc/pcie-tegra194.c b/drivers/pci/controller/dwc/pcie-tegra194.c
> index cc2678490162..d992371a36e6 100644
> --- a/drivers/pci/controller/dwc/pcie-tegra194.c
> +++ b/drivers/pci/controller/dwc/pcie-tegra194.c
> @@ -1949,6 +1949,7 @@ static int tegra_pcie_config_ep(struct tegra194_pcie *pcie,
> if (ret) {
> dev_err(dev, "Failed to initialize DWC Endpoint subsystem: %d\n",
> ret);
> + pm_runtime_disable(dev);
> return ret;
> }
>
> --
> 2.25.1
>
Powered by blists - more mailing lists