[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <11542d9318062155ae5dfaafc7b14bb6@kernel.org>
Date: Thu, 02 Jun 2022 12:35:44 +0100
From: Marc Zyngier <maz@...nel.org>
To: Huacai Chen <chenhuacai@...il.com>
Cc: Huacai Chen <chenhuacai@...ngson.cn>,
Thomas Gleixner <tglx@...utronix.de>,
LKML <linux-kernel@...r.kernel.org>,
Xuefeng Li <lixuefeng@...ngson.cn>,
Jiaxun Yang <jiaxun.yang@...goat.com>
Subject: Re: [PATCH 1/2] irqchip: Adjust Kconfig for Loongson
On 2022-05-31 16:53, Huacai Chen wrote:
> Hi, Marc,
>
> On Tue, May 31, 2022 at 8:52 PM Marc Zyngier <maz@...nel.org> wrote:
>>
>> On 2022-05-31 12:59, Huacai Chen wrote:
>> > We are preparing to add new Loongson (based on LoongArch, not
>> > compatible
>> > with old MIPS-based Loongson) support.
>>
>> Please drop this blurb from all your patches. It adds zero
>> information.
> OK, will be removed.
>
>>
>> > HTVEC will be shared by both old
>> > and new Loongson processors, so we adjust its description. HTPIC is
>> > only
>> > used by MIPS-based Loongson, so we add a MIPS dependency. PCH_PIC and
>> > PCH_MSI will have some arch-specific code, so we remove the
>> > COMPILE_TEST
>> > dependency to avoid build warnings.
>> >
>> > Signed-off-by: Huacai Chen <chenhuacai@...ngson.cn>
>>
>> No cover letter, no indication of what this applies on, no mention
>> of how this relates to the ongoing irqchip review.
>>
>> What do you want me to do with this?
> Sorry about the confusion; as suggested by you and Arnd, these two
> patches
> are the minimal changes required on irqchip's side to make the port
> build,
> without introducing any non-reviewed pieces of code. I originally
> wanted to
> send the patches then quickly reply you in the asm-generic thread, but
> unfortunately I lost Internet connectivity at my site until you have
> replied.
>
> You are knowledgeable, and have taught me much; I owe you many thanks.
> However, as my native language is not English, I realize I may sound
> impolite
> or inappropriate from time to time, making some of you unhappy.
> (Actually I
> had to ask Xuerui to translate this reply for me, in case I get
> something
> wrong again.) I'll try to improve in the future and I hope you'll
> understand.
No worries. English isn't my native language either, and I somehow
developed
a thick skin when it comes to perceived attitude. So please don't
apologise,
and keep working with us.
Thanks,
M.
--
Jazz is not dead. It just smells funny...
Powered by blists - more mailing lists