linux-kernel - Re: [PATCH v4 1/3] dt-bindings: trivial-devices: Add two I2C TPM devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 2 Jun 2022 08:48:48 -0500
From:   Rob Herring <robh@...nel.org>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
        Alexander Steffen <Alexander.Steffen@...ineon.com>
Cc:     jarkko@...nel.org, linux-kernel@...r.kernel.org,
        linux-integrity@...r.kernel.org, devicetree@...r.kernel.org,
        peterhuewe@....de, jgg@...pe.ca, krzysztof.kozlowski+dt@...aro.org,
        Johannes Holland <johannes.holland@...ineon.com>,
        Amir Mizinski <amirmizi6@...il.com>
Subject: Re: [PATCH v4 1/3] dt-bindings: trivial-devices: Add two I2C TPM
 devices

On Thu, May 26, 2022 at 02:29:56PM +0200, Krzysztof Kozlowski wrote:
> On 25/05/2022 18:58, Alexander Steffen wrote:
> > Both are supported by the upcoming tpm_tis_i2c driver.
> > 
> > Signed-off-by: Alexander Steffen <Alexander.Steffen@...ineon.com>
> > ---
> >  Documentation/devicetree/bindings/trivial-devices.yaml | 4 ++++
> >  1 file changed, 4 insertions(+)
> > 
> > diff --git a/Documentation/devicetree/bindings/trivial-devices.yaml b/Documentation/devicetree/bindings/trivial-devices.yaml
> > index 550a2e5c9e05..dc52822331dd 100644
> > --- a/Documentation/devicetree/bindings/trivial-devices.yaml
> > +++ b/Documentation/devicetree/bindings/trivial-devices.yaml
> > @@ -135,6 +135,8 @@ properties:
> >            - infineon,slb9635tt
> >              # Infineon SLB9645 I2C TPM (new protocol, max 400khz)
> >            - infineon,slb9645tt
> > +            # Infineon SLB9673 I2C TPM 2.0
> > +          - infineon,slb9673
> >              # Infineon TLV493D-A1B6 I2C 3D Magnetic Sensor
> >            - infineon,tlv493d-a1b6
> >              # Infineon Multi-phase Digital VR Controller xdpe11280
> > @@ -323,6 +325,8 @@ properties:
> >            - st,24c256
> >              # Ambient Light Sensor with SMBUS/Two Wire Serial Interface
> >            - taos,tsl2550
> > +            # TCG TIS-compliant TPM with I2C interface
> > +          - tcg,tpm_tis-i2c
> 
> One flavor uses tpm-tis, another tpm_tis... I guess it is too late to
> make it consistent, but let's stick to the one more reasonable, so:
> "tpm-tis-i2c".

Neither should be used except perhaps as a fallback. Does 'TCG 
TIS-compliant TPM' encompass every property of a device? Power supplies, 
resets, interrupts, quirks, etc.?

Rob