linux-kernel - Re: [External] : Re: [PATCH 4.19 01/20] nfc: st21nfca: Fix potential buffer overflows in EVT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 2 Jun 2022 20:30:33 +0400
From:   Denis Efremov <denis.e.efremov@...cle.com>
To:     Pavel Machek <pavel@....cz>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        theflamefire89@...il.com
Cc:     linux-kernel@...r.kernel.org, stable@...r.kernel.org,
        Jordy Zomer <jordy@...ing.systems>,
        Krzysztof Kozlowski <krzysztof.kozlowski@...onical.com>,
        "David S. Miller" <davem@...emloft.net>
Subject: Re: [External] : Re: [PATCH 4.19 01/20] nfc: st21nfca: Fix potential
 buffer overflows in EVT_TRANSACTION

Hi,

On 6/2/22 20:12, Pavel Machek wrote:
> Hi!
> 
>> commit 4fbcc1a4cb20fe26ad0225679c536c80f1648221 upstream.
>>
>> It appears that there are some buffer overflows in EVT_TRANSACTION.
>> This happens because the length parameters that are passed to memcpy
>> come directly from skb->data and are not guarded in any way.
>>
>> Signed-off-by: Jordy Zomer <jordy@...ing.systems>
>> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@...onical.com>
>> Signed-off-by: David S. Miller <davem@...emloft.net>
>> Signed-off-by: Denis Efremov <denis.e.efremov@...cle.com>
>> Signed-off-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> 
> It seems that this patch causes an memory leak, transaction does not
> seem to be freed in the error paths.
> 
> (I also wonder if the skb should be freed in the error paths...?)
> 
> Reported-by: <theflamefire89@...il.com>

Same for upstream code and it looks like the problem existed even
before this patch. I'll prepare an upstream patch and cc it to stable.

Thanks,
Denis