linux-kernel - Re: [PATCH v1 1/1] iio: adc: lpc18xx_adc: Switch from of headers to mod

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20220603182628.36f3a170@jic23-huawei>
Date:   Fri, 3 Jun 2022 18:26:28 +0100
From:   Jonathan Cameron <jic23@...nel.org>
To:     Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc:     Jonathan Cameron <Jonathan.Cameron@...wei.com>,
        André Gustavo Nakagomi Lopez <andregnl@....br>,
        linux-iio@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org,
        Lars-Peter Clausen <lars@...afoo.de>,
        Vladimir Zapolskiy <vz@...ia.com>
Subject: Re: [PATCH v1 1/1] iio: adc: lpc18xx_adc: Switch from of headers to
 mod_devicetable.h

On Wed,  1 Jun 2022 00:22:18 +0300
Andy Shevchenko <andriy.shevchenko@...ux.intel.com> wrote:

> There is nothing directly using of specific interfaces in this driver,
> so lets not include the headers.
> 
> While at it, drop dependency to OF, which currently makes no sense.
> 
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Applied
> ---
>  drivers/iio/adc/Kconfig       | 2 +-
>  drivers/iio/adc/lpc18xx_adc.c | 3 +--
>  2 files changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/iio/adc/Kconfig b/drivers/iio/adc/Kconfig
> index 448ae243cd31..b9e913e25a5d 100644
> --- a/drivers/iio/adc/Kconfig
> +++ b/drivers/iio/adc/Kconfig
> @@ -562,7 +562,7 @@ config LP8788_ADC
>  config LPC18XX_ADC
>  	tristate "NXP LPC18xx ADC driver"
>  	depends on ARCH_LPC18XX || COMPILE_TEST
> -	depends on OF && HAS_IOMEM
> +	depends on HAS_IOMEM
>  	help
>  	  Say yes here to build support for NXP LPC18XX ADC.
>  
> diff --git a/drivers/iio/adc/lpc18xx_adc.c b/drivers/iio/adc/lpc18xx_adc.c
> index ae9c9384f23e..42e6cd6fa6f7 100644
> --- a/drivers/iio/adc/lpc18xx_adc.c
> +++ b/drivers/iio/adc/lpc18xx_adc.c
> @@ -17,10 +17,9 @@
>  #include <linux/iio/driver.h>
>  #include <linux/io.h>
>  #include <linux/iopoll.h>
> +#include <linux/mod_devicetable.h>
>  #include <linux/module.h>
>  #include <linux/mutex.h>
> -#include <linux/of.h>
> -#include <linux/of_device.h>
>  #include <linux/platform_device.h>
>  #include <linux/regulator/consumer.h>
>